Conversation
theimpulson
commented
Dec 24, 2025
- I carefully read the contribution guidelines and agree to them.
- I have tested the API against NewPipe.
- I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
891bee7 to
8931e18
Compare
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
8931e18 to
1cd5e64
Compare
|
We cannot update checkstyle as latest version seems to require JDK 17 and above while we are enforcing JDK 11 bytecode. |
I figured this out with https://docs.gradle.org/current/userguide/toolchains.html#toolchains_for_tasks |
Also force it to run with JDK 21 Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
ff96000 to
8972df0
Compare
There was a problem hiding this comment.
We should apply the use of the newer JDK to all files:
NewPipeExtractor/build.gradle.kts
Line 19 in 8972df0
https://github.com/TeamNewPipe/NewPipeExtractor/blob/8972df0a062fc98b623d8e286d83b8aea4343747/jitpack.yml
I think the policy was to keep the compile JDK low and to not use new language features to support the lowest LTS version, which is now 17 as 11 went EOL this year. Should we stick to that? @Stypox @FireMasterK
Can we go ahead with this PR for now and do this discussion separately to unblock it as bumping JDK version isn't the aim for this PR? |
Yeah I guess it makes sense to switch to Java 17 now |