Skip to content

Update Gradle and dependencies#1422

Merged
Stypox merged 4 commits intodevfrom
depUpdate
Jan 17, 2026
Merged

Update Gradle and dependencies#1422
Stypox merged 4 commits intodevfrom
depUpdate

Conversation

@theimpulson
Copy link
Copy Markdown
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@theimpulson theimpulson added the dependencies Pull requests that update a dependency file label Dec 24, 2025
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
@theimpulson
Copy link
Copy Markdown
Member Author

We cannot update checkstyle as latest version seems to require JDK 17 and above while we are enforcing JDK 11 bytecode.

@theimpulson
Copy link
Copy Markdown
Member Author

We cannot update checkstyle as latest version seems to require JDK 17 and above while we are enforcing JDK 11 bytecode.

I figured this out with https://docs.gradle.org/current/userguide/toolchains.html#toolchains_for_tasks

Also force it to run with JDK 21

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should apply the use of the newer JDK to all files:

languageVersion.set(JavaLanguageVersion.of(11))

https://github.com/TeamNewPipe/NewPipeExtractor/blob/8972df0a062fc98b623d8e286d83b8aea4343747/jitpack.yml

I think the policy was to keep the compile JDK low and to not use new language features to support the lowest LTS version, which is now 17 as 11 went EOL this year. Should we stick to that? @Stypox @FireMasterK

@theimpulson
Copy link
Copy Markdown
Member Author

We should apply the use of the newer JDK to all files:

languageVersion.set(JavaLanguageVersion.of(11))

https://github.com/TeamNewPipe/NewPipeExtractor/blob/8972df0a062fc98b623d8e286d83b8aea4343747/jitpack.yml

I think the policy was to keep the compile JDK low and to not use new language features to support the lowest LTS version, which is now 17 as 11 went EOL this year. Should we stick to that? @Stypox @FireMasterK

Can we go ahead with this PR for now and do this discussion separately to unblock it as bumping JDK version isn't the aim for this PR?

@Stypox Stypox merged commit a88b50e into dev Jan 17, 2026
2 of 4 checks passed
@Stypox
Copy link
Copy Markdown
Member

Stypox commented Jan 17, 2026

I think the policy was to keep the compile JDK low and to not use new language features to support the lowest LTS version, which is now 17 as 11 went EOL this year. Should we stick to that?

Yeah I guess it makes sense to switch to Java 17 now

@theimpulson theimpulson deleted the depUpdate branch February 28, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants