Skip to content

fix:unify noagent set in construct and inference#104

Merged
siyuan-youtu merged 1 commit intomainfrom
fix/unify_noagent
Oct 11, 2025
Merged

fix:unify noagent set in construct and inference#104
siyuan-youtu merged 1 commit intomainfrom
fix/unify_noagent

Conversation

@siyuan-youtu
Copy link
Copy Markdown
Contributor

No description provided.

@siyuan-youtu siyuan-youtu requested a review from Copilot October 11, 2025 09:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unifies the validation logic for mode configuration by ensuring both construction and triggers modes use the same valid_modes validation set. It also adds helpful comments about the noagent option for performance optimization.

  • Updated construction mode validation to use the centralized valid_modes list instead of hardcoded values
  • Added clarifying comments about the noagent mode option for performance improvement

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
config/config_loader.py Updated construction mode validation to use consistent valid_modes list
config/base_config.yaml Added comments explaining the noagent performance option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@siyuan-youtu siyuan-youtu merged commit 97a4489 into main Oct 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants