feat:dynamic retrieval display on frontend by siyuan-youtu · Pull Request #97 · TencentCloudADP/youtu-graphrag

siyuan-youtu · 2025-10-08T13:44:18Z

No description provided.

Copilot

Pull Request Overview

This PR implements dynamic retrieval display functionality on the frontend by adding multi-language support with real-time progress tracking and comprehensive WebSocket-based communication for Q&A operations.

Key Changes:

Multi-language support: Replaced hardcoded Chinese text with dynamic English/Chinese language switching functionality
Real-time WebSocket communication: Added comprehensive WebSocket messaging for live Q&A progress updates with sub-question tracking and IRCoT step visualization
Streamlined backend processing: Removed complex security hardening and simplified file upload handling while adding async processing for better performance

Reviewed Changes

Copilot reviewed 17 out of 29 changed files in this pull request and generated 8 comments.

File	Description
frontend/index.html	Complete frontend overhaul with dynamic language switching, real-time Q&A progress display, and WebSocket integration
backend.py	Simplified upload logic, added comprehensive WebSocket Q&A progress updates, and improved async processing
docs/*	Removed entire documentation directory and related files
.github/workflows/publish-docs.yml	Removed GitHub Pages documentation deployment workflow

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-08T13:53:26Z

backend.py

+
 import os
-import re
 import sys


The removed import re is still used in the file at line 774 where it's imported as _re. Consider importing re at the top of the file instead of importing it within the function for better code organization.

Copilot · 2025-10-08T13:53:26Z

frontend/index.html

        <div id="upload" class="tab-content">
            <div class="card">
-                <h2 data-i18n="upload_documents_title">上传文档</h2>
+                                <h2 id="uploadDocumentsTitle">Upload Documents</h2>


Inconsistent indentation detected. This line has excessive indentation compared to surrounding lines which may indicate a formatting issue.

Suggested change

<h2 id="uploadDocumentsTitle">Upload Documents</h2>

<h2 id="uploadDocumentsTitle">Upload Documents</h2>

Copilot · 2025-10-08T13:53:26Z

frontend/index.html

+                                <h2 id="uploadDocumentsTitle">Upload Documents</h2>
                <div class="upload-area" id="uploadArea">
                    <div class="upload-icon">📁</div>
-                    <h3 data-i18n="drag_drop_files">拖拽文件到此处</h3>
-                    <p data-i18n="or_click_browse">或点击浏览文件</p>
-                    <p style="font-size: 12px; color: rgba(255,255,255,0.6); margin-top: 12px;" data-i18n="supported_formats">
-                        当前支持格式：.json
+                                        <h3 id="uploadDragTitle">Drag & Drop Files Here</h3>
+                                        <p id="uploadDragDesc">or click to browse files</p>
+                                        <p id="uploadSupports" style="font-size: 12px; color: rgba(255,255,255,0.6); margin-top: 12px;">
+                                                Currently supports: .json
                    </p>
                    <div style="margin-top: 20px; padding: 15px; background: rgba(255,255,255,0.1); border-radius: 10px; text-align: left; font-size: 11px; color: rgba(255,255,255,0.8);">
-                        <div style="font-weight: 600; margin-bottom: 8px;" data-i18n="sample_format">📄 示例格式 (.json)：</div>
-                        <pre style="margin: 0; font-family: 'JetBrains Mono', 'Monaco', 'Menlo', 'Ubuntu Mono', monospace; background: rgba(0,0,0,0.3); padding: 8px; border-radius: 5px; overflow-x: auto;" id="sample-format-content">
+                                                <div id="uploadSampleHeader" style="font-weight: 600; margin-bottom: 8px;">📄 Sample Format (.json):</div>


Inconsistent indentation pattern with excessive whitespace. Lines 1089-1092 have irregular indentation that doesn't follow the established pattern in the file.

Copilot · 2025-10-08T13:53:27Z

frontend/index.html

                    <div style="margin-top: 20px; padding: 15px; background: rgba(255,255,255,0.1); border-radius: 10px; text-align: left; font-size: 11px; color: rgba(255,255,255,0.8);">
-                        <div style="font-weight: 600; margin-bottom: 8px;" data-i18n="sample_format">📄 示例格式 (.json)：</div>
-                        <pre style="margin: 0; font-family: 'JetBrains Mono', 'Monaco', 'Menlo', 'Ubuntu Mono', monospace; background: rgba(0,0,0,0.3); padding: 8px; border-radius: 5px; overflow-x: auto;" id="sample-format-content">
+                                                <div id="uploadSampleHeader" style="font-weight: 600; margin-bottom: 8px;">📄 Sample Format (.json):</div>


Excessive indentation that's inconsistent with the surrounding code structure. This should be aligned with the proper indentation level.

Suggested change

<div id="uploadSampleHeader" style="font-weight: 600; margin-bottom: 8px;">📄 Sample Format (.json):</div>

<div id="uploadSampleHeader" style="font-weight: 600; margin-bottom: 8px;">📄 Sample Format (.json):</div>

Copilot · 2025-10-08T13:53:27Z

frontend/index.html

+                                        <button class="btn" id="uploadBtn" disabled onclick="uploadFiles()">Upload Files</button>
+                                        <button class="btn btn-secondary" id="clearUploadBtn" onclick="clearFiles()">Clear</button>


Inconsistent indentation with excessive whitespace that doesn't match the established indentation pattern in the file.

Copilot · 2025-10-08T13:53:27Z

backend.py

-        await send_progress_update(client_id, "construction", 2, "Cleaning old cache files...")
-
+
+        await send_progress_update(client_id, "construction", 2, "清理旧缓存文件...")


Hard-coded Chinese text in progress messages should use the same i18n approach as the frontend to maintain consistency and support multiple languages.

Copilot · 2025-10-08T13:53:27Z

backend.py

-        await send_progress_update(client_id, "construction", 5, "Initializing graph builder...")
-
+        
+        await send_progress_update(client_id, "construction", 5, "初始化图构建器...")


Hard-coded Chinese text in progress messages should use the same i18n approach as the frontend to maintain consistency and support multiple languages.

Copilot · 2025-10-08T13:53:28Z

backend.py

-        await send_progress_update(client_id, "construction", 10, "Loading configuration and corpus...")
-
+        
+        await send_progress_update(client_id, "construction", 10, "加载配置和语料库...")


Hard-coded Chinese text in progress messages should use the same i18n approach as the frontend to maintain consistency and support multiple languages.

Copilot

Pull Request Overview

Copilot reviewed 17 out of 29 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-08T15:35:18Z

frontend/index.html

        <div id="upload" class="tab-content">
            <div class="card">
-                <h2 data-i18n="upload_documents_title">上传文档</h2>
+                                <h2 id="uploadDocumentsTitle">Upload Documents</h2>


Excessive indentation found. The line has too many leading spaces compared to surrounding code.

Copilot · 2025-10-08T15:35:18Z

frontend/index.html

+                                        <h3 id="uploadDragTitle">Drag & Drop Files Here</h3>
+                                        <p id="uploadDragDesc">or click to browse files</p>
+                                        <p id="uploadSupports" style="font-size: 12px; color: rgba(255,255,255,0.6); margin-top: 12px;">
+                                                Currently supports: .json


Inconsistent indentation levels. These lines have excessive leading spaces and should be aligned consistently with surrounding HTML elements.

Copilot · 2025-10-08T15:35:19Z

frontend/index.html

                    <div style="margin-top: 20px; padding: 15px; background: rgba(255,255,255,0.1); border-radius: 10px; text-align: left; font-size: 11px; color: rgba(255,255,255,0.8);">
-                        <div style="font-weight: 600; margin-bottom: 8px;" data-i18n="sample_format">📄 示例格式 (.json)：</div>
-                        <pre style="margin: 0; font-family: 'JetBrains Mono', 'Monaco', 'Menlo', 'Ubuntu Mono', monospace; background: rgba(0,0,0,0.3); padding: 8px; border-radius: 5px; overflow-x: auto;" id="sample-format-content">
+                                                <div id="uploadSampleHeader" style="font-weight: 600; margin-bottom: 8px;">📄 Sample Format (.json):</div>


Excessive indentation found. This line has significantly more leading spaces than necessary.

Copilot · 2025-10-08T15:35:19Z

backend.py

 import os
-import re
 import sys
 import json


Removed import statement for 're' module but regular expressions are still used later in the code (lines 774, _re.search). This will cause a runtime error.

Copilot

Pull Request Overview

Copilot reviewed 17 out of 29 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

frontend/index.html:1

[nitpick] Missing spaces after commas in the file extension list for better readability.

<!DOCTYPE html>

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-08T15:44:21Z

backend.py

 from utils.logger import logger
 import ast
-import main as graphrag_main



The line import main as graphrag_main was removed but the import statement appears to be incomplete or missing context. Ensure all necessary imports are properly maintained.

Suggested change

import main as graphrag_main

siyuan-youtu added 2 commits October 8, 2025 21:39

feat:dynamic display of retrieval process on the front end.

f9a3396

remove docs auto build

939d43f

siyuan-youtu changed the title ~~Dynamic retrieval display~~ feat:Dynamic retrieval display Oct 8, 2025

siyuan-youtu changed the title ~~feat:Dynamic retrieval display~~ feat:dynamic retrieval display on frontend Oct 8, 2025

siyuan-youtu requested a review from Copilot October 8, 2025 13:48

Copilot AI reviewed Oct 8, 2025

View reviewed changes

siyuan-youtu added 3 commits October 8, 2025 22:13

update send message to eng

44e12bf

update send message to eng

d06f531

update support file format

c36c931

siyuan-youtu requested a review from Copilot October 8, 2025 15:34

Copilot AI reviewed Oct 8, 2025

View reviewed changes

code format

9e6818f

siyuan-youtu requested a review from Copilot October 8, 2025 15:43

Copilot AI reviewed Oct 8, 2025

View reviewed changes

siyuan-youtu merged commit bae8ff3 into main Oct 8, 2025
1 check passed

siyuan-youtu deleted the dynamic_retrieval_display branch October 10, 2025 11:16

	<h2 id="uploadDocumentsTitle">Upload Documents</h2>
	<h2 id="uploadDocumentsTitle">Upload Documents</h2>

	<div id="uploadSampleHeader" style="font-weight: 600; margin-bottom: 8px;">📄 Sample Format (.json):</div>
	<div id="uploadSampleHeader" style="font-weight: 600; margin-bottom: 8px;">📄 Sample Format (.json):</div>

		<button class="btn" id="uploadBtn" disabled onclick="uploadFiles()">Upload Files</button>
		<button class="btn btn-secondary" id="clearUploadBtn" onclick="clearFiles()">Clear</button>

		await send_progress_update(client_id, "construction", 2, "Cleaning old cache files...")


		await send_progress_update(client_id, "construction", 2, "清理旧缓存文件...")

Conversation

siyuan-youtu commented Oct 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants