Update mod to Minecraft 1.21.9 #903

sakura-ryoko · 2025-09-17T01:42:08Z

I also sent a PR for PAPI for PatBox.

sakura-ryoko · 2025-09-25T21:03:06Z

This port should be solid for Release time.

NotRyken

Found a couple of issues using this while testing my own mods.

src/main/java/com/terraformersmc/modmenu/gui/widget/ModListWidget.java

src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ChildEntry.java

sakura-ryoko · 2025-09-28T19:55:21Z

See if the changes satisfies the requests.

NotRyken

Appears to work correctly.

src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ChildEntry.java

src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ParentEntry.java

src/main/resources/fabric.mod.json

src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ParentEntry.java

src/main/java/com/terraformersmc/modmenu/gui/widget/ModListWidget.java

haykam821

The 'Toggle Filter Options' and 'Configure...' buttons do not change the cursor shape unlike other buttons. Links, unlike those generated by commands such as /tellraw @s {click_event: {action: open_url, url: "https://example.org"}, text: Example}, also do not change the cursor shape.

In addition, when clicking the 'Website' or 'Issues' buttons and returning to the mods screen, the description of the currently selected mod is not restored.

1.21.9-pre1 Slight cleanup Bump PAPI, fix Icon Alignment by 2 px Bump PRE2 Bump PRE3 Bump PRE4 Bump RC.1, address comments. Bump PAPI Fix formatting Update src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ChildEntry.java Update src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ParentEntry.java Update src/main/resources/fabric.mod.json Update src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ParentEntry.java Update src/main/java/com/terraformersmc/modmenu/gui/widget/ModListWidget.java Co-Authored-By: haykam821 <[email protected]>

sakura-ryoko · 2025-09-30T14:52:42Z

@haykam821 -- See the changes. There seems to have been a bug with how the DescriptionList was getting updated; by doing a simple if (mod != selectedMod) {} check.

haykam821

The selection highlight for parent mods is misaligned:

In addition, expanding the children of a parent mod incorrectly scrolls the selected mod into view, and child mods are moved more to the right than before.

… the right side as well.

haykam821

The layout remains misaligned compared to the previous Minecraft 1.21.8 version. I recommend running both versions in windowed mode to allow switching between the two layouts to ensure that they match up.

introduce ModListEntry `offsetY` primarily to "fix" the alignment of the top-most Entry to align with 1.21.8's layout; and then each entry render's with the offset set. Set to 0 for no Y shift.

sakura-ryoko · 2025-10-01T16:01:39Z

The layout remains misaligned compared to the previous Minecraft 1.21.8 version. I recommend running both versions in windowed mode to allow switching between the two layouts to ensure that they match up.

In order for the mods list to "align" with 1.21.8, I had to add a 2 px yOffset, and revert the text line changes.

… (Issue # 769)

adr278 · 2025-10-02T15:52:03Z

(I also couldn't open an issue on your fork) unsure of who's fault this is, but if this is of any help:
I crashed while clicking inside Dynamic FPS' tab
I was using this: https://github.com/sakura-ryoko/ModMenu/actions/runs/18168097762
logs: https://mclo.gs/wR5kEYh

sakura-ryoko · 2025-10-02T15:57:55Z

(I also couldn't open an issue on your fork) unsure of who's fault this is, but if this is of any help: I crashed while clicking inside Dynamic FPS' tab I was using this: https://github.com/sakura-ryoko/ModMenu/actions/runs/18168097762 logs: https://mclo.gs/wR5kEYh

That is a problem with the IMPL of the mod that you are clicking on; not Mod Menu's fault. I have tested this feature with MaLiLib.

PressableWidget.onPress() is 'Missing'

adr278 · 2025-10-02T16:00:04Z

(I also couldn't open an issue on your fork) unsure of who's fault this is, but if this is of any help: I crashed while clicking inside Dynamic FPS' tab I was using this: https://github.com/sakura-ryoko/ModMenu/actions/runs/18168097762 logs: https://mclo.gs/wR5kEYh

That is a problem with the mod that you are clicking on; not Mod Menu's fault. I have tested this feature with MaLiLib.

oh alright 👍
thanks for letting me know, much appreciated for the update too ❤️

danielwerg · 2025-10-02T17:50:26Z

Thank you updating this!

I had small issue with + sign and whatever element it belong too, not sure if this is mod menu issue (nothing happens when you click +)

2025-10-02_17-46-31.mp4

^ Chat Heads mod but also same issue applies to ClickThrough Plus as well

sakura-ryoko · 2025-10-02T18:04:14Z

Thank you updating this!

I had small issue with + sign and whatever element it belong too, not sure if this is mod menu issue (nothing happens when you click +)
2025-10-02_17-46-31.mp4

^ Chat Heads mod but also same issue applies to ClickThrough Plus as well

The Pull Requests are not for Mod Support; See Issues

Prospector · 2025-10-02T23:06:22Z

awesome!

sakura-ryoko changed the title ~~[1.21.9]: Port to 1.21.9-pre1~~ [1.21.9]: Port to 1.21.9-pre2 Sep 19, 2025

sakura-ryoko changed the title ~~[1.21.9]: Port to 1.21.9-pre2~~ [1.21.9]: Port to 1.21.9-pre4+ Sep 24, 2025

NotRyken suggested changes Sep 28, 2025

View reviewed changes

src/main/java/com/terraformersmc/modmenu/gui/widget/ModListWidget.java Outdated Show resolved Hide resolved

src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ChildEntry.java Outdated Show resolved Hide resolved

sakura-ryoko changed the title ~~[1.21.9]: Port to 1.21.9-pre4+~~ [1.21.9]: Port to 1.21.9-rc1+ Sep 28, 2025

NotRyken approved these changes Sep 29, 2025

View reviewed changes

haykam821 reviewed Sep 30, 2025

View reviewed changes

haykam821 requested changes Sep 30, 2025

View reviewed changes

sakura-ryoko force-pushed the 1.21.9-test branch from 6e56a87 to 3698ce6 Compare September 30, 2025 03:08

fix: Description list de-sync & add "hover" cursors; URL null handling.

ef3e302

Bump to Release 1.21.9

0171213

haykam821 changed the title ~~[1.21.9]: Port to 1.21.9-rc1+~~ Update mod to Minecraft 1.21.9 Sep 30, 2025

haykam821 requested changes Sep 30, 2025

View reviewed changes

update: Icon / Text spacing across parent / child mod entries; and on…

33e7d39

… the right side as well.

sakura-ryoko requested a review from haykam821 September 30, 2025 18:57

haykam821 requested changes Oct 1, 2025

View reviewed changes

Abelkrijgtalles mentioned this pull request Oct 1, 2025

Update to 1.21.9 [NeoForge] YaLTeR/MouseTweaks#189

Closed

revert text alignment in favor of using getContentY() for desc list;

ea54e21

introduce ModListEntry `offsetY` primarily to "fix" the alignment of the top-most Entry to align with 1.21.8's layout; and then each entry render's with the offset set. Set to 0 for no Y shift.

sakura-ryoko requested a review from haykam821 October 1, 2025 17:33

blackmidiuser mentioned this pull request Oct 2, 2025

Update to 1.21.9 and 1.21.10 please #909

Closed

notate fix: move "update" icon to match the "Realms" icon's position.…

3a9d204

… (Issue # 769)

nick9509 mentioned this pull request Oct 2, 2025

Bug: Not able to open cfg screen TeamMidnightDust/MidnightControls#368

Closed

adr278 mentioned this pull request Oct 2, 2025

Missing "PressableWidget.onPress()" mod menu integration for 1.21.9 juliand665/Dynamic-FPS#269

Closed

adr278 mentioned this pull request Oct 2, 2025

1.21.9 update ItsJustMiaouss/ijm-tweaks#5

Closed

Prospector merged commit c08eeef into TerraformersMC:1.21.6 Oct 2, 2025
1 check passed

sakura-ryoko deleted the 1.21.9-test branch October 2, 2025 23:29

Update mod to Minecraft 1.21.9 #903

Update mod to Minecraft 1.21.9 #903

Uh oh!

Conversation

sakura-ryoko commented Sep 17, 2025

Uh oh!

sakura-ryoko commented Sep 25, 2025

Uh oh!

NotRyken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sakura-ryoko commented Sep 28, 2025

Uh oh!

NotRyken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haykam821 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sakura-ryoko commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haykam821 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haykam821 left a comment

Choose a reason for hiding this comment

Uh oh!

sakura-ryoko commented Oct 1, 2025

Uh oh!

adr278 commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sakura-ryoko commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adr278 commented Oct 2, 2025

Uh oh!

danielwerg commented Oct 2, 2025

Uh oh!

sakura-ryoko commented Oct 2, 2025

Uh oh!

Prospector commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

haykam821 left a comment •

edited

Loading

sakura-ryoko commented Sep 30, 2025 •

edited

Loading

haykam821 left a comment •

edited

Loading

adr278 commented Oct 2, 2025 •

edited

Loading

sakura-ryoko commented Oct 2, 2025 •

edited

Loading