Skip to content

Conversation

@henkelmax
Copy link
Contributor

@henkelmax henkelmax commented Dec 18, 2025

@coredex-source
Copy link

coredex-source commented Dec 18, 2025

Ah yes, my bad.
#943
EDIT: This one is more complete anyways.

@gniftygnome
Copy link
Contributor

We have a few more fixes going into 1.21.11; hopefully I can get that done this week. And I'll work on Ferry at some point here; either v3.1 or v4 depending on the size of the changes. I'll mention here when those are finished.

@gniftygnome
Copy link
Contributor

I've created a new branch for 26.1; could you please rebase to that? There will be a number of changes given all the stuff I've merged into 1.21.11 the past few days.

I've also updated Ferry to Gradle 9, as version 3.1. It's not tested yet though. The odds are it may need a little more tweaking.

@henkelmax henkelmax changed the base branch from 1.21.11 to 26.1 December 22, 2025 08:07
@henkelmax
Copy link
Contributor Author

I've also updated Ferry to Gradle 9, as version 3.1. It's not tested yet though. The odds are it may need a little more tweaking.

Yeah there are still errors.

https://github.com/TerraformersMC/GradleScripts/blob/2.7/fabric-mod.gradle#L22-L23

These lines should be removed as they are already in the java block.

@gniftygnome
Copy link
Contributor

Wow yeah I didn't look at it closely when I updated those. The java block itself was duplicated, completely identical. Removed one of those too.

@henkelmax
Copy link
Contributor Author

Wow yeah I didn't look at it closely when I updated those. The java block itself was duplicated, completely identical. Removed one of those too.

https://github.com/TerraformersMC/GradleScripts/blob/157bef48c975a82b77eac25e19464a5dc7ba7455/ferry.gradle#L23

Ferry 3.1 still links to the fabric mod Gradle for 3.0

@gniftygnome
Copy link
Contributor

Yup, sorry. I meant to debug this myself, I just ran out of time. That's corrected now too.

@henkelmax
Copy link
Contributor Author

Failed to apply plugin class 'net.fabricmc.loom.LoomGradlePlugin'.
'net.fabricmc.loom.LoomGradlePlugin' is neither a plugin or a rule source and cannot be applied.

This is related to https://github.com/TerraformersMC/GradleScripts/blob/883a5801b5e169930c3924eee8e97694d57da17e/fabric-mod.gradle#L20 I think.

The new loom uses net.fabricmc.fabric-loom instead of fabric-loom as plugin ID for unobfuscated minecraft, that might be related.

@gniftygnome
Copy link
Contributor

Well it was trying to load Loom 1.6, also. I've kind of guessed at what those values should be. Probably Ferry should get converted to the new plugin API but I've had issues trying to do that with Ferry before, I think due to the fact Ferry itself is loaded too late for the new API to get Loom loaded in time.

I'm going to see about getting a test environment set up for this so we don't have to keep doing it piecemeal.

@gniftygnome
Copy link
Contributor

OK it works now. ("Works" meaning it produces the jars with the right names.) Publishing remains to be tested, but that doesn't block the PR.

@gniftygnome
Copy link
Contributor

gniftygnome commented Dec 23, 2025

BTW the CurseForge label for 26.1 snapshot is ... 26.1-snapshot. :)

@henkelmax
Copy link
Contributor Author

henkelmax commented Dec 23, 2025

BTW the CurseForge label for 26.1 snapshot is ... 26.1-snapshot. :)

Yeah CurseForge just added that tag yesterday, so I havent changed it yet.


Ferry still uses modImplementation (https://github.com/TerraformersMC/GradleScripts/blob/e4c397f8532f7366a2483218f6221c78aa586f5b/fabric-mod.gradle#L89) Which doesnt work for unobfuscated loom.

@gniftygnome
Copy link
Contributor

Grrr. I removed those methods from ferry.gradle. It didn't occur to me they were also duplicated in fabric-mod.gradle. Why

I've removed them, but also, just use implementation and api, etc. The entire reason for those Ferry methods was to allow the user to switch specific things back and forth between the mod version and the normal one (i.e. modImplementation vs implementation). In a post-remapping world there is no point.

@henkelmax
Copy link
Contributor Author

Perfect, I think we are good now.

@henkelmax henkelmax marked this pull request as ready for review December 23, 2025 09:28
@gniftygnome
Copy link
Contributor

Yes. Nothing to do about placeholder API until Patbox ports it.

@gniftygnome gniftygnome merged commit e09b7eb into TerraformersMC:26.1 Dec 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants