-
Notifications
You must be signed in to change notification settings - Fork 191
Port to 26.1-snapshot-1 #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ah yes, my bad. |
|
We have a few more fixes going into 1.21.11; hopefully I can get that done this week. And I'll work on Ferry at some point here; either v3.1 or v4 depending on the size of the changes. I'll mention here when those are finished. |
|
I've created a new branch for 26.1; could you please rebase to that? There will be a number of changes given all the stuff I've merged into 1.21.11 the past few days. I've also updated Ferry to Gradle 9, as version 3.1. It's not tested yet though. The odds are it may need a little more tweaking. |
Yeah there are still errors. https://github.com/TerraformersMC/GradleScripts/blob/2.7/fabric-mod.gradle#L22-L23 These lines should be removed as they are already in the java block. |
|
Wow yeah I didn't look at it closely when I updated those. The java block itself was duplicated, completely identical. Removed one of those too. |
Ferry 3.1 still links to the fabric mod Gradle for 3.0 |
|
Yup, sorry. I meant to debug this myself, I just ran out of time. That's corrected now too. |
This is related to https://github.com/TerraformersMC/GradleScripts/blob/883a5801b5e169930c3924eee8e97694d57da17e/fabric-mod.gradle#L20 I think. The new loom uses |
|
Well it was trying to load Loom 1.6, also. I've kind of guessed at what those values should be. Probably Ferry should get converted to the new plugin API but I've had issues trying to do that with Ferry before, I think due to the fact Ferry itself is loaded too late for the new API to get Loom loaded in time. I'm going to see about getting a test environment set up for this so we don't have to keep doing it piecemeal. |
|
OK it works now. ("Works" meaning it produces the jars with the right names.) Publishing remains to be tested, but that doesn't block the PR. |
|
BTW the CurseForge label for 26.1 snapshot is ... |
Yeah CurseForge just added that tag yesterday, so I havent changed it yet. Ferry still uses |
|
Grrr. I removed those methods from ferry.gradle. It didn't occur to me they were also duplicated in fabric-mod.gradle. Why I've removed them, but also, just use implementation and api, etc. The entire reason for those Ferry methods was to allow the user to switch specific things back and forth between the mod version and the normal one (i.e. modImplementation vs implementation). In a post-remapping world there is no point. |
|
Perfect, I think we are good now. |
|
Yes. Nothing to do about placeholder API until Patbox ports it. |
Uh oh!
There was an error while loading. Please reload this page.