tweak how and when the 'v' prefix is applied by the update checker. #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mods start their version strings with something other than a number or a 'v' prefix such as Sodium and Simple Voice Chat (examples below) which can make the 'v' prefix applied by the update checker look a bit messy.
This simply checks if the first character of a version string isn't a number (using
!Character.isDigit) and appends.nonNumericto the translation key which is a duplicate of the previous key without the 'v' prefix. Versions starting with a number aren't changed.Sodium before:
Sodium after:
Simple Voice Chat before:
Simple Voice Chat after:
Fabric Api before and after:
