Open
Conversation
Add a new parameter that is a list of paths that are included in the js/ts rule for building, and pass in the test directory through that path. This allows TerriaMap to avoid building the test sources, which means it no longer requires TerriaJS's devDependencies to be installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
TerriaJS-part of TerriaJS/TerriaMap#730
Add a new parameter that is a list
of paths that are included in the js/ts
rule for building, and pass in the test
directory through that path.
This allows TerriaMap to avoid building
the test sources, which means it no longer
requires TerriaJS's devDependencies to be
installed.
Test me
In TerriaMap with TerriaJS/TerriaMap#740 applied: remove
fetch-mockfrompackage.jsonfollowed by runningyarn install, and then runyarn gulp releaseand see that TerriaMap builds.Checklist
doc/.