Open
Conversation
Adds custom tiling scheme factory and custom tiling scheme support for WMS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Summary of changes:
CameraViewfrom polygon extent to more accurately describe the current viewThis is required when some CRS (eg Antarctica) require more than 2 latlon points to describe an extent precisely
This is used by the plugin to initialize the map with custom projection
TBD: Add tests for the new classes
Test me
Note that for the below tests, the proj4leaflet-plugin has be enabled and configured for the CI branch. The plugin is required for rendering custom projections. The plugin works by overriding the traits for WMS items using this CrsModelStratum.
Using base maps with custom projection
Previewing datasets with custom projection
(Some of the Antarctica datasets are slow to load so it might take a bit for the preview to appear)
Adding datasets with custom projection
When the base map supports the custom projection
Note some of the layers have a low max zoom so they'll disappear if you zoom in too close
When the base map does not support the custom projection
Restoring share links
Checklist
doc/.