fix: Use searchPattern argument in GetFiles method to complete the logic#988
Merged
mergify[bot] merged 4 commits intoTestableIO:mainfrom May 17, 2023
Merged
fix: Use searchPattern argument in GetFiles method to complete the logic#988mergify[bot] merged 4 commits intoTestableIO:mainfrom
mergify[bot] merged 4 commits intoTestableIO:mainfrom
Conversation
It should use the searchPattern argument to complete the logic.
AK1llv
changed the title
AK1llv
changed the title
Contributor
|
+1 👍 |
Contributor
Author
|
@fgreinacher there is also a problem with the Codacy Static Code Analysis |
Contributor
Author
|
|
fgreinacher
approved these changes
May 17, 2023
Contributor
fgreinacher
left a comment
fgreinacher
left a comment
There was a problem hiding this comment.
Nice catch, thanks for the fix!
vbreuss
referenced
this pull request
in Testably/Testably.Abstractions
May 19, 2023
…19.2.29 (#312) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.2.26` -> `19.2.29` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.2.29`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.29) ##### What's Changed - chore(deps): update dependency microsoft.net.test.sdk to v17.6.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/989](https://togithub.com/TestableIO/System.IO.Abstractions/pull/989) - chore(deps): update dependency dotnet-sdk to v7.0.302 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/990](https://togithub.com/TestableIO/System.IO.Abstractions/pull/990) - fix: Use searchPattern argument in GetFiles method to complete the logic by [@​AK1llv](https://togithub.com/AK1llv) in [https://github.com/TestableIO/System.IO.Abstractions/pull/988](https://togithub.com/TestableIO/System.IO.Abstractions/pull/988) ##### New Contributors - [@​AK1llv](https://togithub.com/AK1llv) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/988](https://togithub.com/TestableIO/System.IO.Abstractions/pull/988) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.26...v19.2.29 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS44OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuODkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
This is addressed in release v19.2.29. |
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should use the searchPattern argument to complete the logic.
I found it while working with MockDirectoryInfo.EnumerateFiles(searchPattern, enumerationOptions)
It didnt respect the searchPattern and my tests failed, so I decided to check the source.