Update Strings/RemoveDuplicatedCharacters.php#180
Open
khouloudhaddad wants to merge 9 commits intoTheAlgorithms:masterfrom
Open
Update Strings/RemoveDuplicatedCharacters.php#180khouloudhaddad wants to merge 9 commits intoTheAlgorithms:masterfrom
khouloudhaddad wants to merge 9 commits intoTheAlgorithms:masterfrom
Conversation
Co-authored-by: Brandon Johnson <bbj1979@gmail.com>
…into khouloudHaddad
khouloudhaddad
changed the title
Author
|
Done Adding RemoveDuplicateCharacters to the Directory. |
darwinz
reviewed
Jan 22, 2025
darwinz
reviewed
Jan 22, 2025
Comment on lines
+33
to
+34
| } | ||
|
|
Contributor
There was a problem hiding this comment.
The linter wants you to remove the extra new line at the end of this file.
Co-authored-by: Brandon Johnson <bbj1979@gmail.com>
Author
|
Fix done |
darwinz
reviewed
Feb 3, 2025
| { | ||
| $this->assertSame('aAbB', removeDuplicateCharacters('aAaAaAbBbB')); | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
This file needs 1 empty new line at the end of the file. The other file needs just 1 but has two. 👍🏻
anandfresh
approved these changes
Mar 5, 2025
Contributor
|
@khouloudhaddad I can't merge this until we get the linter to pass. Can you make the change I mentioned here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.