Merged
Conversation
…tribute to FlushAttributeValues
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances LDAP helper functions by improving error handling, renaming methods for clarity, and adding support for flushing attributes when no values are provided.
- Renamed and updated the base-DN existence check to return an error alongside the boolean.
- Extended
OverwriteAttributeValuesto callFlushAttributeValueswhen given an empty slice. - Renamed
FlushAttributetoFlushAttributeValuesfor consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| network/ldap/naming_contexts.go | Renamed BaseDNExists to DistinguishedNameExists, updated signature and docs. |
| network/ldap/modify.go | Added empty-slice handling in OverwriteAttributeValues; renamed flush method. |
Comments suppressed due to low confidence (1)
network/ldap/modify.go:187
- New conditional branch for empty attribute values should be covered by unit tests to verify
FlushAttributeValuesis invoked correctly.
if len(attrVals) == 0 {
…ct/Manticore into improve-ldap-functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.