[bugfix] (*KeyCredential).Unmarshal should return errors but never panic, fixe…#35
Merged
p0dalirius merged 1 commit intomainfrom Oct 31, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the KeyCredential.Unmarshal method to improve error handling, bounds checking, and code clarity. It also adds a basic test case for the unmarshal functionality.
- Adds comprehensive bounds checking to prevent slice out-of-bounds panics
- Improves error messages with contextual information using error wrapping
- Fixes the entry type parsing to correctly read from the appropriate offset
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| windows/keycredential/KeyCredential.go | Refactored Unmarshal method with improved bounds checking, error handling, and documentation |
| windows/keycredential/KeyCredential_test.go | Added test case for Unmarshal method to validate error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p0dalirius
deleted the
KeyCredential-Unmarshal-should-return-errors-but-never-panic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s #34