Skip to content

Added a -p argument to the mkdir in the Cyberchef install#435

Merged
ShutdownRepo merged 2 commits into
ThePorgs:devfrom
lap1nou:fix-cyberchef-install
Feb 27, 2025
Merged

Added a -p argument to the mkdir in the Cyberchef install#435
ShutdownRepo merged 2 commits into
ThePorgs:devfrom
lap1nou:fix-cyberchef-install

Conversation

@lap1nou
Copy link
Copy Markdown
Member

@lap1nou lap1nou commented Feb 25, 2025

Description

When building the light image, the function install_cyberchef is ran twice because the light image run package_most_used AND package_misc. Thus if the mkdir call has not a -p argument, the image building fails because the directory already exist.

Related issues

N / A

Point of attention

N / A

@ShutdownRepo
Copy link
Copy Markdown
Member

Haha thank you
We don't even need the pipeline on that one, approving and putting on hold until we are able to build a nightly. Will merge once we do 👍

@ShutdownRepo ShutdownRepo added ready for merge in the waitlist for merge, requires preliminary steps bugfix It's a bird, it's a plane labels Feb 25, 2025
@qu35t-code
Copy link
Copy Markdown
Member

qu35t-code commented Feb 26, 2025

@lap1nou, next time, please sign your commits ! Otherwise I can't force the merge, I have to wait @ShutdownRepo

@ShutdownRepo
Copy link
Copy Markdown
Member

No biggie, signing is mostly for us maintainers
I thought you had the ability to force merge unsigned commits though, will fix that

@lap1nou
Copy link
Copy Markdown
Member Author

lap1nou commented Feb 26, 2025

I didn't knew that, will do for next.

@ShutdownRepo ShutdownRepo merged commit a4da135 into ThePorgs:dev Feb 27, 2025
@ShutdownRepo ShutdownRepo mentioned this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix It's a bird, it's a plane ready for merge in the waitlist for merge, requires preliminary steps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants