Telescope: Deal correctly with empty marks on delete and move up/down#633
Open
iserpent wants to merge 1 commit intoThePrimeagen:harpoon2from
Open
Telescope: Deal correctly with empty marks on delete and move up/down#633iserpent wants to merge 1 commit intoThePrimeagen:harpoon2from
iserpent wants to merge 1 commit intoThePrimeagen:harpoon2from
Conversation
The empty marks are preserved to conform with the initial idea to keep the stable indexes for the existing marks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telescope extension breaks when a mark is removed from the middle of the list.
The pull request is to add some more consistency here:
Not fixed:
This pull request is not directly related to the encode/decode issue, but rather complements the functionality. It doesn't depend on the encode/decode related pull requests and can be merged independently.