Merged
Conversation
Allows CMake to find system hidapi.
Owner
|
i think that closing the other pull and using this one will be better as it pack the fixes in a single pull |
Closed
added 2 commits
May 3, 2017 18:15
The flag -std=c++11 is needed for xBRZ to compile but it is not correctly passed by CMake, at least in macOS. Added it to the corresponding CMakeLists.txt The flag is added if compiling under macOS or Linux.
This also adds the flag when compiling under Linux as well as macOS.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now everything compiles correctly in macOS. I had to fix two files. There's more information on the commits.