feat(http-proxy-agent): emit 'proxyConnect' event#390
Open
abhu85 wants to merge 2 commits intoTooTallNate:mainfrom
Open
feat(http-proxy-agent): emit 'proxyConnect' event#390abhu85 wants to merge 2 commits intoTooTallNate:mainfrom
abhu85 wants to merge 2 commits intoTooTallNate:mainfrom
Conversation
Adds `proxyConnect` event emission to `http-proxy-agent` for parity with `https-proxy-agent`. The event is emitted on both the request and the agent instance when the socket connects to the proxy server. The event payload includes: - `socket`: The connected socket to the proxy server This allows users to access the socket connection details (remoteAddress, localPort, etc.) when the proxy connection is established. Fixes TooTallNate#368 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 78c1edf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@abhu85 is attempting to deploy a commit to the Nathan Rajlich's projects Team on Vercel. A member of the Team first needs to authorize it. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #368 - Emit the
proxyConnectevent forhttp-proxy-agentfor parity withhttps-proxy-agent.This PR adds
proxyConnectevent emission tohttp-proxy-agent. The event is emitted on both the request and the agent instance when the socket connects to the proxy server.Changes
ProxyConnectinterface withsocketpropertyproxyConnectevent on the request after socket connectsproxyConnectevent on the agent instance after socket connectsEvent Payload
Since
http-proxy-agentdoesn't use the CONNECT method (it sends requests directly through the proxy), the event payload is different fromhttps-proxy-agent. The payload includes:This gives users access to the connected socket so they can inspect connection details like
remoteAddress,localPort, etc.Usage Example
Test Cases
should emit "proxyConnect" event on the requestshould emit "proxyConnect" event on the agent