Merged
Conversation
spohlenz
reviewed
Aug 23, 2024
Member
|
Thank you for this. I've added in Rails 8.x Gemfiles in #471 to continue tracking any breaking changes. Please review my code comment when you get a chance and then I'll get this merged in. |
Member
|
Thanks again. I've added #472 to deal with the remaining deprecation warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Rails 8 (main branch checkout), there are a bunch of errors (kwargs) and deprecation warnings, because Rails deprecates Routes.rb
post :something => 'action', arrow functions because of performance optim PRHere is the diff, that fixes it for me.
As Rails8 is not released, it would be best, to wait to merge this until beta-releases, in case they change anything about this feature, or new deprecations occur.
In the meantime, other people can use my branch: