Skip to content

Support Rails 8.0 routes#470

Merged
spohlenz merged 1 commit intoTrestleAdmin:mainfrom
zealot128-os:rails8
Aug 24, 2024
Merged

Support Rails 8.0 routes#470
spohlenz merged 1 commit intoTrestleAdmin:mainfrom
zealot128-os:rails8

Conversation

@zealot128
Copy link
Contributor

@zealot128 zealot128 commented Aug 22, 2024

When using Rails 8 (main branch checkout), there are a bunch of errors (kwargs) and deprecation warnings, because Rails deprecates Routes.rb post :something => 'action', arrow functions because of performance optim PR

Here is the diff, that fixes it for me.

As Rails8 is not released, it would be best, to wait to merge this until beta-releases, in case they change anything about this feature, or new deprecations occur.

In the meantime, other people can use my branch:

 gem 'trestle', git: 'https://github.com/zealot128-os/trestle.git', branch: 'rails8'

@coveralls
Copy link

coveralls commented Aug 23, 2024

Coverage Status

coverage: 90.597% (-0.09%) from 90.682%
when pulling ce6396b on zealot128-os:rails8
into a18e54f on TrestleAdmin:main.

@spohlenz
Copy link
Member

Thank you for this. I've added in Rails 8.x Gemfiles in #471 to continue tracking any breaking changes.

Please review my code comment when you get a chance and then I'll get this merged in.

@spohlenz spohlenz merged commit bc0470d into TrestleAdmin:main Aug 24, 2024
@spohlenz
Copy link
Member

Thanks again. I've added #472 to deal with the remaining deprecation warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants