Spelling fixes and additional call stat reporting#798
Merged
robotastic merged 1 commit intoTrunkRecorder:masterfrom Apr 24, 2023
Merged
Spelling fixes and additional call stat reporting#798robotastic merged 1 commit intoTrunkRecorder:masterfrom
robotastic merged 1 commit intoTrunkRecorder:masterfrom
Conversation
Collaborator
|
Great upgrades!! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor fixes:
call->get_stats()should provide downstream plugins (such as MQTT) a call's number as a shorter alternative to the longid.Calls stats should also provide the
monitoringStateto better identify outlier trunk recorder events such as duplicate calls or the lack of available recorders/sources. This would give users more detailed state information thanstateandrecStatecurrently provide.Removed a leftover "Call_impl" reference to be consistent with other
infolevel console text.Corrected the spelling of the "elapsed" key used in call stats.