Transmission archive fix#834
Merged
robotastic merged 2 commits intoTrunkRecorder:masterfrom Jul 11, 2023
Merged
Conversation
Contributor
Author
|
Below is the error leading to this crash that was investigated on the t-r discord. |
Collaborator
|
Nice Catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beginning with trunk-recorder 4.6, transmission .wav files exist in a temporary directory and either get deleted, or moved to the
captureDirstructure iftransmissionArchiveis set in the config file.Related to PR #796, trunk-recorder may crash if it attempts file operations on a non-existent transmission .wav in the
tempDir.This fix simply uses the existing
checkIfFile()to verify if the file exists before attempting to move a transmission .wav from thecaptureDir.