Conversation
Admin deployment to production is now handled by Ghost-Moya's cd-admin.yml, triggered via the cd.yml orchestrator on every main merge. The deploy_admin job (which built admin with GHOST_CDN_URL, uploaded an artifact, and dispatched to deploy-admin.yml in Moya) is no longer needed.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Velo CI Failure AnalysisClassification: ⚪ CI FAIL
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26724 +/- ##
=======================================
Coverage 73.24% 73.24%
=======================================
Files 1534 1534
Lines 120760 120760
Branches 14610 14610
=======================================
Hits 88445 88445
+ Misses 31300 31284 -16
- Partials 1015 1031 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The
deploy_adminjob built admin with a hardcodedGHOST_CDN_URL, uploaded the artifact, and dispatched todeploy-admin.ymlin Ghost-Moya to push files to the production GCS bucket. This was the legacy path for updating production admin-forward.Admin deployment is now fully handled by Ghost-Moya's
cd-admin.ymlsub-workflow, which thecd.ymlorchestrator calls on every main merge withenvironment: both. The admin build artifact uploaded byjob_docker_build_production(asadmin-build-cd) is consumed bycd-admin.ymldirectly — no separate build withGHOST_CDN_URLoverride is needed becausecd-admin.ymlrewrites asset paths at upload time.Merge order: This PR should be merged first — it removes the
deploy_adminjob that dispatches todeploy-admin.ymlin Ghost-Moya. Ghost-Moya PR #178 then deletes that target workflow. Merging in this order avoidsdeploy_adminfailing on every main merge due to dispatching to a non-existent workflow.