Skip to content

Removed legacy deploy_admin job from CI#26724

Draft
rob-ghost wants to merge 1 commit intomainfrom
chore/delete-deploy-admin
Draft

Removed legacy deploy_admin job from CI#26724
rob-ghost wants to merge 1 commit intomainfrom
chore/delete-deploy-admin

Conversation

@rob-ghost
Copy link
Contributor

@rob-ghost rob-ghost commented Mar 5, 2026

The deploy_admin job built admin with a hardcoded GHOST_CDN_URL, uploaded the artifact, and dispatched to deploy-admin.yml in Ghost-Moya to push files to the production GCS bucket. This was the legacy path for updating production admin-forward.

Admin deployment is now fully handled by Ghost-Moya's cd-admin.yml sub-workflow, which the cd.yml orchestrator calls on every main merge with environment: both. The admin build artifact uploaded by job_docker_build_production (as admin-build-cd) is consumed by cd-admin.yml directly — no separate build with GHOST_CDN_URL override is needed because cd-admin.yml rewrites asset paths at upload time.

Merge order: This PR should be merged first — it removes the deploy_admin job that dispatches to deploy-admin.yml in Ghost-Moya. Ghost-Moya PR #178 then deletes that target workflow. Merging in this order avoids deploy_admin failing on every main merge due to dispatching to a non-existent workflow.

Admin deployment to production is now handled by Ghost-Moya's
cd-admin.yml, triggered via the cd.yml orchestrator on every main
merge. The deploy_admin job (which built admin with GHOST_CDN_URL,
uploaded an artifact, and dispatched to deploy-admin.yml in Moya)
is no longer needed.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a0ca8a3-32bb-4f35-a3f0-cb8ce605eb9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/delete-deploy-admin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ErisDS
Copy link
Member

ErisDS commented Mar 5, 2026

🤖 Velo CI Failure Analysis

Classification: ⚪ CI FAIL

  • Workflow: CI
  • Run: View failed run
    What failed: Workflow CI failed.
    Why: Velo could not extract enough detail to provide a full explanation.
    Action:
    Inspect the failed step/logs and update the PR to address the failure.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.24%. Comparing base (515a4d6) to head (02265e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #26724   +/-   ##
=======================================
  Coverage   73.24%   73.24%           
=======================================
  Files        1534     1534           
  Lines      120760   120760           
  Branches    14610    14610           
=======================================
  Hits        88445    88445           
+ Misses      31300    31284   -16     
- Partials     1015     1031   +16     
Flag Coverage Δ
admin-tests 54.31% <ø> (ø)
e2e-tests 73.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants