Fix: relocate RESEARCH_FINDINGS.md and TOOL_SCAFFOLD.md to spec/#37
Merged
4eckd merged 2 commits intotools-roadmapfrom Mar 26, 2026
Merged
Fix: relocate RESEARCH_FINDINGS.md and TOOL_SCAFFOLD.md to spec/#374eckd merged 2 commits intotools-roadmapfrom
4eckd merged 2 commits intotools-roadmapfrom
Conversation
These documentation files were placed directly in skills/ causing the "Check Skill Contribution Quality" CI check to fail. The workflow treats every entry in skills/ as a skill directory and requires SKILL.md + LICENSE.txt — neither doc file is a skill, so validation errors out. Moving both to spec/ (where project-level documentation belongs) unblocks the tools-roadmap PR without modifying any workflow logic. https://claude.ai/code/session_01DwJPGbN7xTeGXDaoNMbN7A
- Add YAML frontmatter + file structure validation rows for mermaid-terminal, project-status-tool, and ux-journey-mapper (all PASS) - Document the root cause and resolution of the Check Skill Contribution Quality CI failure (RESEARCH_FINDINGS.md + TOOL_SCAFFOLD.md relocated from skills/ to spec/) - Update total skill count to 9 https://claude.ai/code/session_01DwJPGbN7xTeGXDaoNMbN7A
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/RESEARCH_FINDINGS.md→spec/RESEARCH_FINDINGS.mdskills/TOOL_SCAFFOLD.md→spec/TOOL_SCAFFOLD.mdRoot Cause
The
Check Skill Contribution QualityCI job (inskill-contribution-check.yml) parsesgit diff --name-only origin/main...HEADand extracts every entry underskills/as a skill directory name. It then requires each "skill" to containSKILL.mdandLICENSE.txt.RESEARCH_FINDINGS.mdandTOOL_SCAFFOLD.mdare project documentation files — not skills — but they were committed directly intoskills/, causing the check to emit:Deliverables
skills/RESEARCH_FINDINGS.mdrelocated tospec/skills/TOOL_SCAFFOLD.mdrelocated tospec/Success Metrics
Check Skill Contribution Qualitycheck passes on the tools-roadmap PR (PR Tools roadmap #35)spec/directory now contains all project-level reference documentsTest Plan
Check Skill Contribution Qualitypasses on this PRspec/RESEARCH_FINDINGS.mdandspec/TOOL_SCAFFOLD.mdare accessiblehttps://claude.ai/code/session_01DwJPGbN7xTeGXDaoNMbN7A