Skip to content

Fix: relocate RESEARCH_FINDINGS.md and TOOL_SCAFFOLD.md to spec/#37

Merged
4eckd merged 2 commits intotools-roadmapfrom
claude/fix-failed-test-RbwUa
Mar 26, 2026
Merged

Fix: relocate RESEARCH_FINDINGS.md and TOOL_SCAFFOLD.md to spec/#37
4eckd merged 2 commits intotools-roadmapfrom
claude/fix-failed-test-RbwUa

Conversation

@4eckd
Copy link
Copy Markdown

@4eckd 4eckd commented Mar 26, 2026

Summary

  • Moves skills/RESEARCH_FINDINGS.mdspec/RESEARCH_FINDINGS.md
  • Moves skills/TOOL_SCAFFOLD.mdspec/TOOL_SCAFFOLD.md

Root Cause

The Check Skill Contribution Quality CI job (in skill-contribution-check.yml) parses git diff --name-only origin/main...HEAD and extracts every entry under skills/ as a skill directory name. It then requires each "skill" to contain SKILL.md and LICENSE.txt.

RESEARCH_FINDINGS.md and TOOL_SCAFFOLD.md are project documentation files — not skills — but they were committed directly into skills/, causing the check to emit:

❌ Validation failed:
  - RESEARCH_FINDINGS.md: Missing SKILL.md
  - RESEARCH_FINDINGS.md: Missing LICENSE.txt
  - TOOL_SCAFFOLD.md: Missing SKILL.md
  - TOOL_SCAFFOLD.md: Missing LICENSE.txt

Deliverables

Deliverable Status
Root cause identified
skills/RESEARCH_FINDINGS.md relocated to spec/
skills/TOOL_SCAFFOLD.md relocated to spec/
No skill content modified
No workflow files modified

Success Metrics

  • Check Skill Contribution Quality check passes on the tools-roadmap PR (PR Tools roadmap #35)
  • All other checks remain green (Validate Skills, Verify Licenses, Check YAML Consistency, etc.)
  • Zero skill directories affected — only file locations changed
  • spec/ directory now contains all project-level reference documents

Test Plan

  • Confirm Check Skill Contribution Quality passes on this PR
  • Confirm PR Tools roadmap #35 (tools-roadmap → main) CI goes green after merge
  • Verify spec/RESEARCH_FINDINGS.md and spec/TOOL_SCAFFOLD.md are accessible

https://claude.ai/code/session_01DwJPGbN7xTeGXDaoNMbN7A

claude added 2 commits March 26, 2026 12:11
These documentation files were placed directly in skills/ causing the
"Check Skill Contribution Quality" CI check to fail. The workflow
treats every entry in skills/ as a skill directory and requires SKILL.md
+ LICENSE.txt — neither doc file is a skill, so validation errors out.

Moving both to spec/ (where project-level documentation belongs)
unblocks the tools-roadmap PR without modifying any workflow logic.

https://claude.ai/code/session_01DwJPGbN7xTeGXDaoNMbN7A
- Add YAML frontmatter + file structure validation rows for mermaid-terminal,
  project-status-tool, and ux-journey-mapper (all PASS)
- Document the root cause and resolution of the Check Skill Contribution
  Quality CI failure (RESEARCH_FINDINGS.md + TOOL_SCAFFOLD.md relocated
  from skills/ to spec/)
- Update total skill count to 9

https://claude.ai/code/session_01DwJPGbN7xTeGXDaoNMbN7A
@4eckd 4eckd mentioned this pull request Mar 26, 2026
@4eckd 4eckd merged commit 801363a into tools-roadmap Mar 26, 2026
@4eckd 4eckd deleted the claude/fix-failed-test-RbwUa branch March 26, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants