Fix skill contribution check: exclude documentation examples from API…#43
Merged
4eckd merged 1 commit intoascii-mockup-skillfrom Mar 26, 2026
Merged
Conversation
… key pattern detection The sensitive pattern check was too strict and caught placeholder examples in markdown documentation (e.g., api_key='your-api-key'). Updated the workflow to: - Only check high-confidence secret patterns (sk-*, AKIA*, ghp_*) in markdown files - Check full pattern set including generic patterns (password=, api_key=, client_secret=) only in code files (.py, .js, .ts, .sh, .txt) - This allows documentation to include example code without false positives Fixes the 'Check for sensitive patterns' validation step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… key pattern detection
The sensitive pattern check was too strict and caught placeholder examples in markdown documentation (e.g., api_key='your-api-key'). Updated the workflow to:
Fixes the 'Check for sensitive patterns' validation step.