fix(client): Use libcap to fix icmp not working in containers as non-root#1056
Merged
TwiN merged 3 commits intoTwiN:masterfrom Apr 1, 2025
Merged
fix(client): Use libcap to fix icmp not working in containers as non-root#1056TwiN merged 3 commits intoTwiN:masterfrom
TwiN merged 3 commits intoTwiN:masterfrom
Conversation
TwiN
approved these changes
Apr 1, 2025
2 tasks
Owner
|
Looks like this is causing an issue: #1057 I may have to revert this if we can't find a fix |
Contributor
Author
|
I think there are three options here:
|
Contributor
Author
Owner
|
The chaotic inside of me just makes me feel like having those using podman deal with it, mostly because podman users are a minority. |
Owner
|
Based on what I'm seeing on containerd/containerd#10434, it seems like CAP_NET_RAW being enabled by default may be changed in the future. I wonder if the current default behavior is why Gatus worked just fine for me on Kubernetes even before this change? |
|
I don't mind that it would be documented for podman users. As a podman user, I'm fine with that :) It seems reasonable to me. |
2 tasks
buroa
added a commit
to buroa/k8s-gitops
that referenced
this pull request
May 31, 2025
…5.18.0) (#3845)" This reverts commit e4d9a5f. See here: TwiN/gatus#1056
TwiN
added a commit
that referenced
this pull request
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #697
This PR modifies the Gatus binary in the container to have the CAP_NET_RAW capability. Gatus can now perform ICMP monitoring without running as a privileged or root container.
Checklist
README.md, if applicable.