Skip to content

Comments

fix(api): Escape endpoint key in URL for raw APIs#1381

Merged
TwiN merged 1 commit intoTwiN:masterfrom
Nedra1998:master
Nov 7, 2025
Merged

fix(api): Escape endpoint key in URL for raw APIs#1381
TwiN merged 1 commit intoTwiN:masterfrom
Nedra1998:master

Conversation

@Nedra1998
Copy link
Contributor

Summary

The raw API endpoints don't escape the endpoint key in the URL properly, while the other API endpoints (badges/chart) do. This results in cases where:

curl "http://myserver/api/v1/endpoints/group_東京/uptimes/1h"

is a 404 but

curl "http://myserver/api/v1/endpoints/group_東京/uptimes/1h/badges.svg"

returns a 200.

This change just copies the previous fix from #1114 and applies it to the raw API endpoins as well.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
    • Built and deployed locally with an endpoint name of 東京 and confirmed API was now returning successfully.
  • Updated documentation in README.md, if applicable.
    • No documentation update needed

@github-actions github-actions bot added the bug Something isn't working label Nov 7, 2025
Nedra1998 referenced this pull request in glanceapp/community-widgets Nov 7, 2025
Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@TwiN TwiN added the area/api Related to the REST API label Nov 7, 2025
@TwiN TwiN merged commit 9e97efa into TwiN:master Nov 7, 2025
3 checks passed
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Nov 14, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.30.0` -> `v5.31.0` |

---

### Release Notes

<details>
<summary>TwiN/gatus (ghcr.io/twin/gatus)</summary>

### [`v5.31.0`](https://github.com/TwiN/gatus/releases/tag/v5.31.0)

[Compare Source](TwiN/gatus@v5.30.0...v5.31.0)

Highlight of this release are the ability to mark announcements as "archived", which renders said announcements in a new `Past Announcements` section at the bottom of the status page (only rendered if there is at least 1 archived announcements), support for markdown in announcements and support for monitoring gRPC health endpoints.

<img width="1166" height="556" alt="image" src="https://github.com/user-attachments/assets/d22a0ea7-c035-4c35-a148-6de097a357b7" />

#### What's Changed
* feat(announcements): Add support for archived announcements and add past announcement section in UI by @&#8203;TwiN in TwiN/gatus#1382
* feat(announcements): add markdown support by @&#8203;Sworyz in TwiN/gatus#1371
* feat(client): Add support for monitoring gRPC endpoints by @&#8203;diamanat in TwiN/gatus#1376
* fix(client): update icmp/ping logic to determine pinger privileged mode by @&#8203;h3mmy in TwiN/gatus#1346
* fix(api): Escape endpoint key in URL for raw APIs by @&#8203;Nedra1998 in TwiN/gatus#1381
* docs(readme): adds ECS fargate module in README by @&#8203;GiamPy5 in TwiN/gatus#1377

#### New Contributors
* @&#8203;GiamPy5 made their first contribution in TwiN/gatus#1377
* @&#8203;h3mmy made their first contribution in TwiN/gatus#1346
* @&#8203;diamanat made their first contribution in TwiN/gatus#1376
* @&#8203;Nedra1998 made their first contribution in TwiN/gatus#1381
* @&#8203;Sworyz made their first contribution in TwiN/gatus#1371

**Full Changelog**: <TwiN/gatus@v5.30.0...v5.31.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41LjAiLCJ1cGRhdGVkSW5WZXIiOiI0Mi41LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImltYWdlIl19-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/2008
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api Related to the REST API bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants