This repository was archived by the owner on Mar 22, 2024. It is now read-only.
Conversation
This was referenced Sep 13, 2023
Closed
kaisalmen
force-pushed
the
issue-46
branch
2 times, most recently
from
1a2a73b to
bb0b92f
Compare
kaisalmen
changed the title
montymxb
reviewed
Sep 19, 2023
Member
montymxb
left a comment
montymxb
left a comment
There was a problem hiding this comment.
General feedback points. There's a large conditional that's built in editorAppBase.ts that can probably be expressed as a series of branches or [a,b,c].some(p => p).
approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
The configuration change detection in
componentDidUpdateis not correct. It interprets model related updates as application configuration updates. This PR introduces better logic to the wrapper and thereby shortens the react-component code.There are now three levels of update protection: