Wrapper: Make codeResources and useDiffEditor optional in EditorAppConfig#670
Merged
Conversation
- Update dependencies along
CGNonofr
reviewed
Jun 3, 2024
- Added eslint rules @typescript-eslint/strict-boolean-expressions and @typescript-eslint/no-unnecessary-condition - Updated dependencies once more
CGNonofr
reviewed
Jun 4, 2024
CGNonofr
reviewed
Jun 4, 2024
Collaborator
Author
|
@CGNonofr eslint produces errors I don't see on Windows, but only on Linux. I can reproduce this locally. |
Collaborator
Author
|
@CGNonofr I got it. Code from the dependent packages in the repo are not available. Type resolution is therefore not correct. The code needs to be built first. |
Collaborator
Author
|
@CGNonofr problems are resolved. This is ready now. |
CGNonofr
approved these changes
Jun 4, 2024
Collaborator
CGNonofr
left a comment
CGNonofr
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With latest changes it is now also possible to remove any
codeResourcesoruseDiffEditorfrom the editor app configuration.Dependencies were updated as well