Skip to content

Move MonacoLanguageClientWrapper to monaco-languageclient#920

Merged
kaisalmen merged 2 commits into
devfrom
move-lc-wrapper
May 6, 2025
Merged

Move MonacoLanguageClientWrapper to monaco-languageclient#920
kaisalmen merged 2 commits into
devfrom
move-lc-wrapper

Conversation

@kaisalmen
Copy link
Copy Markdown
Collaborator

This just movse MonacoLanguageClientWrapper including config and tests to monaco-languageclient. It does not change any beahviour, yet.

It introduces a sub-export monaco-languageclient/warpper and increase the version to 10.0.0-next.0.

This branch is merged to the dev branch and it will contain all the changes needed for #919 until being merged back to main.

@kaisalmen kaisalmen requested a review from CGNonofr as a code owner May 6, 2025 15:57
@kaisalmen kaisalmen marked this pull request as draft May 6, 2025 16:11
@kaisalmen
Copy link
Copy Markdown
Collaborator Author

@CGNonofr this makes monaco-languageclient dependent on vscode-ws-jsonrpc and we did not wanted that in the past. So, maybe this is not a good idea. WDYT?

@CGNonofr
Copy link
Copy Markdown
Collaborator

CGNonofr commented May 6, 2025

@CGNonofr this makes monaco-languageclient dependent on vscode-ws-jsonrpc and we did not wanted that in the past. So, maybe this is not a good idea. WDYT?

Why didn't we want that ? 🤔

@kaisalmen
Copy link
Copy Markdown
Collaborator Author

Why didn't we want that ? 🤔

Good question. Maybe, I did not remember that correctly

@kaisalmen kaisalmen marked this pull request as ready for review May 6, 2025 16:39
@kaisalmen
Copy link
Copy Markdown
Collaborator Author

@CGNonofr ok, I made the adjustment. Build should be green now.

@kaisalmen kaisalmen merged commit 985418f into dev May 6, 2025
1 check passed
@kaisalmen kaisalmen deleted the move-lc-wrapper branch May 6, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants