Skip to content

Add strong naming#67

Merged
Tyrrrz merged 1 commit intoTyrrrz:primefrom
mgravell:marc/strong-name
Mar 25, 2026
Merged

Add strong naming#67
Tyrrrz merged 1 commit intoTyrrrz:primefrom
mgravell:marc/strong-name

Conversation

@mgravell
Copy link
Copy Markdown
Contributor

Closes #66

  • create new snk for the project (sn -k)
  • (global build) specify the snk
  • (main assembly build) enable strong-name-signing

Main tests are green in Rider; secondary tests have some failure with/without the changes 🤷

- create new snk for the project (`sn -k`)
- (global build) specify the snk
- (main assembly build) enable strong-name-signing
@Tyrrrz Tyrrrz added the enhancement New feature or request label Mar 25, 2026
@Tyrrrz Tyrrrz changed the title Propose strong-naming of the main dll Add strong-naming Mar 25, 2026
@Tyrrrz Tyrrrz changed the title Add strong-naming Add strong naming Mar 25, 2026
@Tyrrrz
Copy link
Copy Markdown
Owner

Tyrrrz commented Mar 25, 2026

Thanks!

secondary tests have some failure with/without the changes 🤷

Those are demo tests that are meant to fail. They are excluded from dotnet test, but Rider runs them anyway by default.

@Tyrrrz Tyrrrz merged commit 3da2169 into Tyrrrz:prime Mar 25, 2026
7 checks passed
@mgravell
Copy link
Copy Markdown
Contributor Author

mgravell commented Mar 25, 2026

fix verified as successful (here), cheers

@mgravell mgravell deleted the marc/strong-name branch March 25, 2026 11:56
This was referenced Mar 25, 2026
This was referenced Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing dev-dependency flag breaks usage with strong-named packages

2 participants