83 link each tool to the arc projects that use it or vice versa #200
Conversation
katiebuntic
commented
Oct 24, 2023
katiebuntic
commented
- updating tables to link projects with each tool
…se-it-or-vice-versa
…se-it-or-vice-versa
|
Have fixed linting for you & updated from |
|
@samcunliffe the link checker CI is failing, and I can't work out why. Any ideas? |
|
https://github.com/UCL-MIRSG/UCLH-MPBE-SRR-XNAT is 404 unless you're a member of UCL-MIRSG which we're not all. And TREx is private to UCL-ARC. |
Oh yeah of course! Didn't think of that as I'm part of MIRSG. @katiebuntic you'll need to use public repos generally |
samcunliffe
left a comment
samcunliffe
left a comment
There was a problem hiding this comment.
Looks good to me!
@paddyroddy are you happy?
…se-it-or-vice-versa
paddyroddy
left a comment
paddyroddy
left a comment
There was a problem hiding this comment.
hand on clicked the wrong button
paddyroddy
left a comment
paddyroddy
left a comment
There was a problem hiding this comment.
- I've merged in
main - I've fixed the table formatting issues in
templates.md - I've moved
cookieninjato 🔴 andcookiecutterto 🟢
Requesting changes due to the Gemfile thing
docs/Gemfile.lock
Outdated
| mercenary (>= 0.3.6, < 0.5) | ||
| pathutil (~> 0.9) | ||
| rouge (>= 3.0, < 5.0) | ||
| rogue (>= 3.0, < 5.0) |
There was a problem hiding this comment.
Do we know why this has changed? Is this an actual change or codespell?
There was a problem hiding this comment.
😱 I'm going blind: I thought this was just whitespace.
Good catch.
Yeah I'm 👎 on codespell in pre-commit. I didn't actually realise we had added it.
paddyroddy
left a comment
paddyroddy
left a comment
There was a problem hiding this comment.
I've fixed the Gemfile issue. So happy to merge assuming CI passes @samcunliffe
samcunliffe
deleted the
83-link-each-tool-to-the-arc-projects-that-use-it-or-vice-versa
branch
