Skip to content

Change some residual cookieninja usages to cookiecutter #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paddyroddy merged 2 commits into from
Oct 26, 2023
Merged

Change some residual cookieninja usages to cookiecutter #209

paddyroddy merged 2 commits into from
Oct 26, 2023

Conversation

@paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Oct 25, 2023

Fixes #186

@paddyroddy paddyroddy added the bug Something isn't working label Oct 25, 2023
@paddyroddy paddyroddy requested a review from p-j-smith October 25, 2023 19:59
@paddyroddy paddyroddy self-assigned this Oct 25, 2023
samcunliffe
samcunliffe approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if you specifically want approval from Paul, but since I'm hanging out here.

@matt-graham matt-graham changed the title This wouldn't happen if you used an IDE Change some residual cookieninja usages to cookiecutter Oct 26, 2023
@matt-graham
Copy link
Collaborator

matt-graham commented Oct 26, 2023

In the interests of keeping things welcoming and inclusive I've edited the title of this. We all make mistakes whatever tools we use.

@paddyroddy paddyroddy merged commit d96dd24 into main Oct 26, 2023
@paddyroddy paddyroddy deleted the paddyroddy-patch-1 branch October 26, 2023 09:21
@paddyroddy
Copy link
Member Author

paddyroddy commented Oct 26, 2023

In the interests of keeping things welcoming and inclusive I've edited the title of this. We all make mistakes whatever tools we use.

Sorry, was just having fun

@samcunliffe samcunliffe mentioned this pull request Dec 20, 2023
Merged
samcunliffe added a commit to UCL-ARC/research-software-practices that referenced this pull request Dec 20, 2023
@samcunliffe
Ninja → cutter. (#18)
eb7bc84 
Follows
UCL-ARC/python-tooling#186 and
UCL-ARC/python-tooling#209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samcunliffe samcunliffe samcunliffe approved these changes

@p-j-smith p-j-smith Awaiting requested review from p-j-smith

Assignees

@paddyroddy paddyroddy

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paddyroddy @matt-graham @samcunliffe