allow using full FOV for Parallelproj projector#1261
Draft
KrisThielemans wants to merge 2 commits intoUCL:masterfrom
Draft
allow using full FOV for Parallelproj projector#1261KrisThielemans wants to merge 2 commits intoUCL:masterfrom
KrisThielemans wants to merge 2 commits intoUCL:masterfrom
Conversation
introduce restrict_to_cylindrical_FOV variable/keyword (defaulting to true), identical to what is used in the ray-tracing matrix This variable is a rename of the _use_truncation variable (which was essentially disabled), but now made to work.
KrisThielemans
force-pushed
the
ParallelProjCylFOV
branch
from
e6bbcf2 to
e30cf18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduce
restrict_to_cylindrical_FOVvariable/keyword (defaulting to true), identical to what is used in the ray-tracing matrixThis variable is a rename of the
_use_truncationvariable (which was essentially disabled), but now made to work.This compiles, but I haven't tested yet if it actually does work. Also needs adjusting the example .par file and release notes.