plot formulas doesn't work anymore?

[jordansread]

not sure why this test doesn't catch it:

test_that("points.gsplot accepts formulas",{
  gs <- gsplot() %>%
       points(y~x, data=list(x=-3:3,y=-3:3))
  expect_equal(gs$view$window$xlim, c(-3,3))
  expect_equal(gs$view$window$ylim, c(-3,3))
  gs

})

This fails outside of the test when printing the gs object:

> gs
 Show Traceback

 Rerun with Debug
 Error in formula.default(object, env = baseenv()) : invalid formula 

This is on master branch v ‘0.5.4’

[jordansread]

Should fix this bug and fix the test

[lindsayplatt]

For original issue, see #146 and #159.

In gsplot v0.7.0, this fails when trying to create gs and I think it has to do with changes made to strip_pts. The out object of strip_pts no longer leaves as a vector, but instead as a list so it fails in is.finite() for set_side_lim. See #422

Once the error to generate the gsplot was overcome, the error preventing the plot from printing popped up. It's coming from print >> print.view >> to_gsplot.

Error in terms.formula(formula, data = data) : 
  argument is not a valid model

[ldecicco-USGS]

strip_pts needs help

[lindsayplatt]

get rid of strip_pts
have range.side or something:

• loop through each thing on that side and figure out min and max

[lindsayplatt]

Might be able to do range() and then get range of ranges? Maybe some nuance w/ NaN, NULLs, etc.

Should have good tests, so we can try this and see what happens.

[lindsayplatt]

This requires strip_pts to be fixed first. See #452