fix off-by-one and optimize brute force xref search #1078#1079
Merged
Conversation
when performing a brute force xref search we were ending up off-by-one, update the search to use a ring buffer to reduce seeking and fix xref detection
Collaborator
|
@EliotJones do you want me to wait for you before merging? Or are you okay merging as is? |
Member
Author
|
@BobLd I want to run integration tests first and then try and isolate some test cases because it appears every brute force search would have been broken and I find that hard to believe. |
Member
Author
|
@BobLd this has test coverage now and should be ready to merge, I'll re-run the integration tests to ensure I didn't break anything while adding tests. |
Collaborator
|
@EliotJones sounds great, let me know when good to merge |
BobLd
requested changes
Jul 15, 2025
Collaborator
BobLd
left a comment
BobLd
left a comment
There was a problem hiding this comment.
@EliotJones thanks again for the great help here. Do you mind sealing the CircularByteBuffer class?
Member
Author
|
@BobLd this is ready for merging now 🙏 |
BobLd
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when performing a brute force xref search we were ending up off-by-one, update the search to use a ring buffer to reduce seeking and fix xref detection
I want to do some more testing around this since I don't understand how the existing code ever worked, but I'll let the CI tests run overnight. I'm going away for a week now, potentially more.