fix colorspace error when form xobject contains a transparency group#1088
Merged
fix colorspace error when form xobject contains a transparency group#1088
Conversation
when a form xobject contains a reference to a group xobject this can only be used to change attributes of the transparency imaging model. the old code was setting the main colorspaces incorrectly causing errors when the transparency component had a different number of channels. this was causing #1071 in addition to the failure in file 0000355.pdf of the test corpus
Member
Author
|
With this change we can successfully parse the first 1000 files of the sample corpus 🎉 with the exception of 3 non-PDF files:
and 1 password protected file:
|
BobLd
approved these changes
Jul 19, 2025
Collaborator
|
Note for myself: investigate the CS issue based on the documents |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a form xobject contains a reference to a group xobject this can only be used to change attributes of the transparency imaging model. the old code was setting the main colorspaces incorrectly causing errors when the transparency component had a different number of channels. this was causing #1071 in addition to the failure in file 0000355.pdf of the test corpus
0000355.pdf