[CURA-12065] Fix (sort-of) conflict between per-object and per-mesh retraction.#2154
Closed
[CURA-12065] Fix (sort-of) conflict between per-object and per-mesh retraction.#2154
Conversation
…tings. We don't really have a set way to deal with settings that can both be per-extruder and per-mesh (sometimes called per-object in the engine) -- in general, building something like that would be a (new) feature (gap). This repressents a workaround for a current issue where the overall settings are taken instead of the per-extruder ones, even though in the frontend, no per-mesh settings are overridden. Which happened because it always prefers the per-mesh settings over the per-extruder ones, and since the per-mesh settings where not overridden, it was just the 'top' ones. If you then overrode less then all of the extruders with a specific setting, it would default back to the 'top' settings (but if all extruders where overridden, that counted as not overridden again w.r.t per-extruder). This commit 'fixes' that by assuming that if you have any setting different per extruder, you want that rather than the per mesh ones. This isn't necesarily the case (and also definitely not as granular as can be, it takes all retraction and wipe settings as one....) but it may do the job for now. CURA-12065
wawanbreton
reviewed
Oct 24, 2024
Contributor
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
This really seems hacky to me 😬 I have the feeling that it just moves the issue to an other place. Does it actually fix some cases ? If yes, then I would be ok to integrate it, but with a follow-up ticket to do a bigger refactoring.
Member
Author
It does fix the example case in the jira-ticket. I'm not sure if that's from an actual user though, or if QA made it. |
Member
Author
|
Mothballed. |
Member
Author
|
Closed in favour of #2191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't really have a set way to deal with settings that can both be per-extruder and per-mesh (sometimes called per-object in the engine) -- in general, building something like that would be a (new) feature (gap). This represents a workaround for a current issue where the overall settings are taken instead of the per-extruder ones, even though in the frontend, no per-mesh settings are overridden. Which happened because it always prefers the per-mesh settings over the per-extruder ones, and since the per-mesh settings where not overridden, it was just the 'top' ones. If you then overrode less then all of the extruders with a specific setting, it would default back to the 'top' settings (but if all extruders where overridden, that counted as not overridden again w.r.t per-extruder).
This commit 'fixes' that by assuming that if you have any setting different per extruder, you want that rather than the per mesh ones. This isn't necessarily the case (and also definitely not as granular as can be, it takes all retraction and wipe settings as one....) but it may do the job for now.