Merged
Conversation
tdrwenski
force-pushed
the
s3-radar-server
branch
from
379dffd to
bc690e4
Compare
tdrwenski
force-pushed
the
s3-radar-server
branch
from
bc690e4 to
27ac865
Compare
dopplershift
approved these changes
Oct 2, 2024
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looks good to me. I'm not familiar with all the APIs, but this seems sensible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #361 and depends on functionality added in Unidata/netcdf-java#1388.
Make RadarServer code work for S3 datasets by:
MFileinterface (which has implementations for local and s3 files) instead of aPathobjectMControllerinterface to loop through directories/files (which has implementations for local and S3 files) instead of aDirectoryStreamTests: