Merged
Conversation
Create a generic, two-level disk persisted cache to replace the chronicle-map based caches. The level 1 cache is an in-memory LRU cache implemented with Guava. The level 2 cache holds key/values in an on-disk EclipseStore storage layer. The level 1 cache is item limited; the level 2 cache is lazily indexed, and references can be lazily loaded to feed the level 1 cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Chronicle-Map key-value store with a two level disk-persisted cache. The level 1 cache is an in-memory, item limited cache implemented using Guava. The level 2 cache is a lazily loaded, disk-persisted cache implemented with EclipseStore, and feeds the level 1 cache as needed.
Our mock tests had to be revisited to ensure we were not creating multiple contexts, as the level 2 cache implementation strictly enforces a single active writer.
Closes #569