Merged
Conversation
After the most recent gradle upgrade, some subproject test tasks were running, even when single tests from an unrelated subproject were executed. This was due to the way we were aggregating test results into a root report. This commit removes that code in favor of gradle's test-report-aggregation plugin, which addresses the task dependency issue.
The TDM can only read local catalogs when trying to decide what indexes need to be created, so ignore remote catalogRefs. This will cleanup the TDM logs from needless FileNotFound errors. Also, add a basic tests for reading a GRIB feature collection from a catalogRef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597. Also addresses an issue with the gradle build in that some subproject tests were being run even when a single, unrelated, subproject test was executed.