Image adjustment and fix to "Home Button"

[ra-anders]

Added a new function for image adjustment (contrast, brightness and saturation) and fixed the existing "Go Home" button (css was missing). To enable it you set these properties:

"openSeadragonCenterPanel": {
      "options": {
        ...
        "showHomeControl": true,
        "showAdjustImageControl": true
        ...
      }
    },

In the dialogue for image adjustment the user have the choice to save the settings (this only works if "saveUserSettings" is set to true).

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
universalviewer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 27, 2024 11:45am

[demiankatz]

I haven't tried this hands-on yet, but the code makes sense to me. Just a few questions/suggestions regarding finishing touches.

[demiankatz]

Also, the description of this PR mentions a fix to "Home Button," but I didn't immediately see exactly what was being fixed. Can you elaborate? (Just might be useful to understand what was broken and what has been fixed, especially if it's an opportunity to build a test to catch regressions).

[ra-anders]

Also, the description of this PR mentions a fix to "Home Button," but I didn't immediately see exactly what was being fixed. Can you elaborate? (Just might be useful to understand what was broken and what has been fixed, especially if it's an opportunity to build a test to catch regressions).

Basically all I did was to add the CSS to display it, it was missing for some reason. But all the functionality was there.

                    .xl-mediaquery({
                        display: inline-block !important;
                        cursor: pointer !important;
                        background-image: data-uri('../img/home.png') !important;
                        width: 28px;
                        height: 28px;
                        // margin: 3px !important;
                        img {
                            display: none;
                        }
                        &:focus {
                            .tab-focus();
                        }
                    });

[demiankatz]

Thanks for the adjustments and clarifications, @ra-anders! As I noted at our meeting yesterday, the Steering Group is working through new processes for getting pull requests reviewed and merged, so it may take us a little while to get this finalized... but I think this will be a good candidate for fairly early merging once we get that sorted out. In the meantime, I'll add this to our project board so we don't lose track of it!

[LanieOkorodudu]

I just tested this adjustments features in different browser such as Chrome, Edge, and Firefox. Looks all good. Thanks for your awesome job @ra-anders

[demiankatz]

Thanks, @LanieOkorodudu, that's great! I think then the only thing we might want to talk about further before merging this is how our translation workflow should be handled. I'll note that in the steering group channel on Slack.

[demiankatz]

I think this is ready to merge. Thanks again!