Remove fixed widths from navigation controls (fixes #1066)#1131
Merged
demiankatz merged 2 commits intoUniversalViewer:devfrom Oct 17, 2024
Merged
Remove fixed widths from navigation controls (fixes #1066)#1131demiankatz merged 2 commits intoUniversalViewer:devfrom
demiankatz merged 2 commits intoUniversalViewer:devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
changed the title
demiankatz
changed the title
demiankatz
approved these changes
Oct 17, 2024
Contributor
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
This looks good to me, but I'll wait for one more review before merging! Thanks, @LlGC-jop!
Collaborator
@demiankatz @LlGC-jop I've tested this fix in both Chrome and Firefox, as the issue was initially reported happening in Firefox. Everything looks good on my end, including when I switched the language to French. Thanks @LlGC-jop |
Contributor
|
Thanks, @LanieOkorodudu, I'll merge this now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1066
Removed fixed widths from
.mode labeland.searchthe CY less file.Changes fixed widths to be auto in the main pdf and paging headerpanel less files.
The auto widths seem fine in all languages at both normal and increased letter spacing, and at all screen widths where the panel appears.