Keep focus on gallery button when selected

[Saira-A]

Fixes #1073

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
universalviewer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 21, 2024 2:55pm

[demiankatz]

Thanks, @Saira-A! I think this is probably a relic from the old days when the gallery control worked differently. This seems well worth doing, but I'll hold off on merging until @LanieOkorodudu has a chance to confirm.

Also, a related issue: I notice that if you do focus the gallery collapse button with the keyboard, you can only activate it with spacebar, but that causes the page to scroll down unexpectedly. We probably need to fix the accessibility of that control. That's a problem for a separate issue/PR; let me know if you'd like me to open an issue to document the situation!

[Saira-A]

Thanks, @Saira-A! I think this is probably a relic from the old days when the gallery control worked differently. This seems well worth doing, but I'll hold off on merging until @LanieOkorodudu has a chance to confirm.

Also, a related issue: I notice that if you do focus the gallery collapse button with the keyboard, you can only activate it with spacebar, but that causes the page to scroll down unexpectedly. We probably need to fix the accessibility of that control. That's a problem for a separate issue/PR; let me know if you'd like me to open an issue to document the situation!

Thanks @demiankatz! The collapse button issue is mentioned in #1084 and as you said there it's probably best to break it into smaller tasks

[demiankatz]

Great, thanks for confirming that the issue is already documented!

[jamesmisson]

Code and preview both look good to me.