Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
approved these changes
Mar 7, 2025
Contributor
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Looks good to me -- thanks, @Geoffsc!
Collaborator
|
Thanks for the fix, @Geoffsc! I have tested it, and it works when UV is open on a desktop. @demiankatz, should the settings button also be available in mobile view to access the "About" functionality? |
Contributor
|
@LanieOkorodudu, you raise a good point about the settings dialogue being inaccessible on mobile. I think we should probably open an issue to discuss that situation further, as I suspect it raises some new questions and design considerations. I don't think it needs to delay the completion of this PR, though, as I think that's a separate matter. |
github-project-automation
bot
moved this from IN TESTING
to COMPLETED
in Community Sprint Feb 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1309