Change active tab to @link-color for contrast.#1360
Change active tab to @link-color for contrast.#1360demiankatz merged 2 commits intoUniversalViewer:release-4.2.0from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
left a comment
There was a problem hiding this comment.
@crhallberg, I re-targeted this PR against release-4.2.0 on the assumption that we would like to get this fix into the next release, since it was discovered during testing of the release candidate (and it's a small/simple/safe fix).
One observation, though: you've fixed the tabs in the thumbnail sidebar, but if you switch to the index tab, the selected index item has the lower-contrast color. We should probably fix that as well for consistency.
…ching for @brand-primary).
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @crhallberg, this looks good to me now. I'll wait and see if anyone else has feedback before merging it.
|
Requesting a review from @LanieOkorodudu since I believe this should resolve #1359. |
LanieOkorodudu
left a comment
There was a problem hiding this comment.
@crhallberg This looks so much better now! I also ran the axe DevTools to perform an accessibility audit, and the issues have been resolved. Thank you!
This fixes the contrast issue by bringing tags to AA contrast like the links. If we want AAA contrast, here are some options: