Skip to content

Change active tab to @link-color for contrast.#1360

Merged
demiankatz merged 2 commits intoUniversalViewer:release-4.2.0from
crhallberg:fix-tab-contrast
Apr 22, 2025
Merged

Change active tab to @link-color for contrast.#1360
demiankatz merged 2 commits intoUniversalViewer:release-4.2.0from
crhallberg:fix-tab-contrast

Conversation

@crhallberg
Copy link
Copy Markdown
Contributor

@crhallberg crhallberg commented Apr 3, 2025

This fixes the contrast issue by bringing tags to AA contrast like the links. If we want AAA contrast, here are some options:

  • Tailwind CSS - cyan 500 is the closest color in this palette. We can move to cyan-300 for text and cyan-700 for buttons.
  • Harmony - cyan-300 and cyan-700 for something less vibrant.
  • We can switch hues to the purple or fuchsia that we see on the UV website.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 8:27pm

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crhallberg, I re-targeted this PR against release-4.2.0 on the assumption that we would like to get this fix into the next release, since it was discovered during testing of the release candidate (and it's a small/simple/safe fix).

One observation, though: you've fixed the tabs in the thumbnail sidebar, but if you switch to the index tab, the selected index item has the lower-contrast color. We should probably fix that as well for consistency.

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crhallberg, this looks good to me now. I'll wait and see if anyone else has feedback before merging it.

@demiankatz
Copy link
Copy Markdown
Contributor

Requesting a review from @LanieOkorodudu since I believe this should resolve #1359.

Copy link
Copy Markdown
Collaborator

@LanieOkorodudu LanieOkorodudu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crhallberg This looks so much better now! I also ran the axe DevTools to perform an accessibility audit, and the issues have been resolved. Thank you!

@demiankatz demiankatz merged commit c6b63af into UniversalViewer:release-4.2.0 Apr 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants