Skip to content

Only One Dialogue Overlay at a Time#1365

Merged
demiankatz merged 1 commit intoUniversalViewer:release-4.2.0from
crhallberg:one-dialogue
Apr 22, 2025
Merged

Only One Dialogue Overlay at a Time#1365
demiankatz merged 1 commit intoUniversalViewer:release-4.2.0from
crhallberg:one-dialogue

Conversation

@crhallberg
Copy link
Copy Markdown
Contributor

@crhallberg crhallberg commented Apr 11, 2025 •
edited by demiankatz
Loading

Fix share and terms conflict by only opening one dialogue at a time.

TODO

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 6:47pm

@demiankatz demiankatz changed the base branch from dev to release-4.2.0 April 11, 2025 18:48
demiankatz
demiankatz approved these changes Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll let @LanieOkorodudu reassess as well in case she has any other thoughts... but this makes the terms of service link work consistently between the download and share dialogs (closing the existing open dialog before opening a new one), which seems like the best solution.

@demiankatz demiankatz mentioned this pull request Apr 11, 2025
Closed
@demiankatz
Copy link
Copy Markdown
Contributor

demiankatz commented Apr 11, 2025 •
edited
Loading

I've targeted this to the release-4.2.0 branch since this is a bug fix for an issue discovered during testing of 4.2.0RC2.

LanieOkorodudu
LanieOkorodudu approved these changes Apr 22, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@LanieOkorodudu LanieOkorodudu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crhallberg, @demiankatz. I’ve tested it again, and everything works as expected. Apologies for the delayed response, I’ve just returned to work after a holiday. Thank you for your hard work @crhallberg

@demiankatz demiankatz merged commit 0c192c7 into UniversalViewer:release-4.2.0 Apr 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demiankatz demiankatz demiankatz approved these changes

@LanieOkorodudu LanieOkorodudu LanieOkorodudu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crhallberg @demiankatz @LanieOkorodudu