Make osd controls visible from md+#1372
Make osd controls visible from md+#1372demiankatz merged 1 commit intoUniversalViewer:release-4.2.0from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
left a comment
There was a problem hiding this comment.
@LlGC-jop, this makes sense to me and seems to have the desired effect.
I've re-targeted this PR from dev to release-4.2.0 so the fix can go into the next RC after this is merged.
I'm also seeing the issue where the OSD controls sometimes fail to fade, but I don't know that it has anything to do with the screen size. When I go to the current https://universalviewer.dev, I'm seeing that the controls start out in a "stuck visible" state, and they only start fading out after I shrink and regrow the window. I wonder if some of the work we did to ensure that the controls remain visible when in keyboard focus is sometimes being a little too aggressive. That might need a separate issue, but I don't think it needs to hold up progress here.
@LanieOkorodudu and others, what do you think?
@LlGC-jop, The fix looks good on my end. Thank you for your work on this. |
|
Thanks, @LlGC-jop and @LanieOkorodudu. I am merging this now. I have opened #1375 to track the inconsistent fading behavior we discussed above. Please feel free to add any other thoughts/details there. |
Closes #1369
Adjusts the media queries for the OSD controls so they appear on mid-sized devices (tablets and small laptops).
Oddly the fading behaviour in OSD doesn't seem to work when below 1024px, but I don't see that as a problem because at that size it's likely a touch device, so mouse events wouldn't work anyway.