Skip to content

Make osd controls visible from md+#1372

Merged
demiankatz merged 1 commit intoUniversalViewer:release-4.2.0from
LlGC-jop:fix-1369
Apr 29, 2025
Merged

Make osd controls visible from md+#1372
demiankatz merged 1 commit intoUniversalViewer:release-4.2.0from
LlGC-jop:fix-1369

Conversation

@LlGC-jop
Copy link
Copy Markdown
Contributor

Closes #1369

Adjusts the media queries for the OSD controls so they appear on mid-sized devices (tablets and small laptops).

Oddly the fading behaviour in OSD doesn't seem to work when below 1024px, but I don't see that as a problem because at that size it's likely a touch device, so mouse events wouldn't work anyway.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 1:27pm

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LlGC-jop, this makes sense to me and seems to have the desired effect.

I've re-targeted this PR from dev to release-4.2.0 so the fix can go into the next RC after this is merged.

I'm also seeing the issue where the OSD controls sometimes fail to fade, but I don't know that it has anything to do with the screen size. When I go to the current https://universalviewer.dev, I'm seeing that the controls start out in a "stuck visible" state, and they only start fading out after I shrink and regrow the window. I wonder if some of the work we did to ensure that the controls remain visible when in keyboard focus is sometimes being a little too aggressive. That might need a separate issue, but I don't think it needs to hold up progress here.

@LanieOkorodudu and others, what do you think?

@LanieOkorodudu
Copy link
Copy Markdown
Collaborator

@LlGC-jop, this makes sense to me and seems to have the desired effect.

I've re-targeted this PR from dev to release-4.2.0 so the fix can go into the next RC after this is merged.

I'm also seeing the issue where the OSD controls sometimes fail to fade, but I don't know that it has anything to do with the screen size. When I go to the current https://universalviewer.dev, I'm seeing that the controls start out in a "stuck visible" state, and they only start fading out after I shrink and regrow the window. I wonder if some of the work we did to ensure that the controls remain visible when in keyboard focus is sometimes being a little too aggressive. That might need a separate issue, but I don't think it needs to hold up progress here.

@LanieOkorodudu and others, what do you think?

@LlGC-jop, The fix looks good on my end. Thank you for your work on this.
@demiankatz, I’ve noticed the same behavior as well, though I had assumed it was expected. It does seem worth looking into more closely. It might be a good idea to raise it as a separate issue for now, so we can track and address it properly without holding up the current work.

@demiankatz demiankatz merged commit 32e6a79 into UniversalViewer:release-4.2.0 Apr 29, 2025
5 checks passed
@demiankatz
Copy link
Copy Markdown
Contributor

Thanks, @LlGC-jop and @LanieOkorodudu. I am merging this now. I have opened #1375 to track the inconsistent fading behavior we discussed above. Please feel free to add any other thoughts/details there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OSD zoom controls are hidden from 768px to 1279px

3 participants