Skip to content

Change panel widths on small/mobile screens so they don't cover the whole view (fixes #1370)#1401

Merged
demiankatz merged 7 commits intoUniversalViewer:release-4.2.0from
LlGC-jop:fix-1370
May 8, 2025
Merged

Change panel widths on small/mobile screens so they don't cover the whole view (fixes #1370)#1401
demiankatz merged 7 commits intoUniversalViewer:release-4.2.0from
LlGC-jop:fix-1370

Conversation

@LlGC-jop
Copy link
Copy Markdown
Contributor

@LlGC-jop LlGC-jop commented May 7, 2025

Fixes #1370

Changes panel widths on small/mobile screens so they don't cover the whole view.

Right will be slightly wider than Left because it's for text content.

@LlGC-jop LlGC-jop requested a review from demiankatz May 7, 2025 14:34
@vercel
Copy link
Copy Markdown

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 3:39pm

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LlGC-jop. I'm not sure if this exactly addresses the original ticket, but I'm also not sure if there is any entirely satisfactory solution to this problem, so the question is whether this is an improvement worth merging. I'd be interested in @Saira-A's opinion as the original ticket opener.

My feeling is that this is a bit of an improvement, as it reduces some of the weirder-looking displays... but it's not perfect, as it still can result in things like this:

image

There's also the problem that if you open both panels, resize the window, and hit the mobile footer panel toggle buttons, then both panels seem to close unexpectedly.

However, I think for the common use case of changing the orientation of a tablet, this is probably good enough. Some of the more exotic use cases may be too complicated to fix (or the cost of a fix may exceed the benefit by making code more confusing).

Thoughts?

@demiankatz demiankatz changed the title Fix 1370 Change panel widths on small/mobile screens so they don't cover the whole view (fixes #1370) May 7, 2025
@demiankatz demiankatz changed the base branch from dev to release-4.2.0 May 7, 2025 15:40
Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @LlGC-jop. I've changed the base of this PR so it goes into release 4.2.0 as planned, and I'm approving since I do not object to merging it. However, I'll leave it open until others have time to comment.

@Saira-A
Copy link
Copy Markdown
Contributor

Saira-A commented May 8, 2025

I agree @demiankatz, I think it's an adequate solution

@demiankatz
Copy link
Copy Markdown
Contributor

Thanks, @Saira-A -- merging now so we can move forward with the release candidate.

@demiankatz demiankatz merged commit fad6547 into UniversalViewer:release-4.2.0 May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resizing browser window causes left or right panel to cover center panel

3 participants