Layout Fix: hide empty left and right panels#1416
Merged
demiankatz merged 1 commit intoUniversalViewer:release-4.2.0from May 16, 2025
Merged
Layout Fix: hide empty left and right panels#1416demiankatz merged 1 commit intoUniversalViewer:release-4.2.0from
demiankatz merged 1 commit intoUniversalViewer:release-4.2.0from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
previously approved these changes
May 14, 2025
Contributor
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Looks good and makes sense to me, but I'm interested in what @LlGC-jop thinks, since he did much of the recent CSS redesign and would have a more complete perspective than I do.
I think we should rebase this onto the release-4.2.0 branch so we can include the fix in the next release; let me know if you need any help sorting that out.
Contributor
Author
|
This one rebased quietly. |
demiankatz
approved these changes
May 15, 2025
Contributor
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @crhallberg, this looks good to me! I'll hold off on merging until tomorrow's stand-up, just in case anyone has concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grid is set to 30px for closed panels. When a panel isn't active (audio or single page pdfs) this results in a 30px wide gray bar.
This PR sets the CSS variables to "auto" when a panel is empty, collapsing that space and giving it to the center view.
Florence Nightingale (audio) is a good test for this since it has no left panel. Compare https://universalviewer.dev to preview below!