Conversation
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
|
Thanks, @Saira-A -- I have turned your lists into checkboxes so that we can check things off as we improve them in the documentation (or otherwise resolve them). |
|
Regarding some the options reported as not working: I believe that I'm not sure what The My guess is that The I strongly suspect that As far as I can tell, |
|
Note: I've just alphabetized the list of "needs improvement" settings and consolidated the list of broken or problematic settings. Note that a checked status in the "improved definitions" list means "the setting works and the documentation has been improved" while a checked status in the "don't appear to work / needs more attention" list means "the setting has been investigated and commented on, but follow-up action is likely needed." I'm moving things from the top list to the bottom list when I discover them to be problematic. |
|
Regarding the
These metric settings are set in the config as below: Then these are read in This is based on a relatively quick code read and I am more than open to folks' input in case I missed anything! I am also open to any recommendations on how to explain these settings in a simple, straightforward and terse way. :) |
|
@Saira-A, since we've discovered that uv-iiif-config.json is only used for examples, might it make sense to stop documenting individual settings used there? Assuming the setting definitions are the same and are documented elsewhere, maybe a description that just says "any settings included in this file will override equivalent settings from all modules" (or something like that). Just looking for an opportunity to simplify, if simplification would be appropriate. |
Yes that sounds like a good idea, will do |
Remove uv-iiif-config.json duplicate options
Add footnote [^2]
saveUserSettings
I looked into it and found this: zoomToSearchResultEnabled:
zoomToBoundsEnabled:
So it may be worth keeping them separate but at the very least improving on their current descriptions @LlGC-jop @demiankatz |
|
Thanks, @Saira-A -- I'd agree that for now, just improving the descriptions is a good starting point. We could rename them at some point, but that's a lot more effort, and the focus right now is on documentation. Since you've proven that both settings have a purpose, we can start by clarifying how they interact. Let me know if you want any help drafting or reviewing anything. |
|
Thanks @demiankatz. From #1449 that just leaves these two: currentViewDisabledPercentage - meant to hide the "download current view" option if the current view is the same as the whole image view. The code was lost when the download dialogue was refactored to use React so the config doesnβt work anymore - I think the easiest thing to do would be to just remove it from the config files as well and then create a new issue to add it back in at a later date forceImageMode - only appears to be used in the search footer panel, where it changes the page count to image count. Could just add that to the documentation but keep the footnote warning that it's still being reviewed. Does this sound ok to you? |
zoomToBoundsEnabled
|
@Saira-A, that sounds like a good approach to finish this up; I agree -- let's get rid of currentViewDisabledPercentage and document forceImageMode as-is for now. As you say, we can open an issue to revisit currentViewDisabledPercentage in future. |
forceImageMode
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @Saira-A -- nearly done, but I think this latest one could use some clarification (and sorry that my poor memory prevents me from recalling WHICH clarification is the right one).
I also think the last finishing touch before we take this out of draft mode and merge it is to decide on where the file should live -- maybe we can discuss that during the retrospective.
remove currentViewDisabledPercentage
update forceImageMode
Work in progress. The following options need improved definitions:
and these options don't appear to work, or need more attention in the code (see #1449 for additional tracking of work on cleaning these up):