Skip to content

Remove trimAttributionCount configuration option#1456

Merged
demiankatz merged 5 commits intoUniversalViewer:devfrom
Saira-A:trimAttributionCount
Jun 20, 2025
Merged

Remove trimAttributionCount configuration option#1456
demiankatz merged 5 commits intoUniversalViewer:devfrom
Saira-A:trimAttributionCount

Conversation

@Saira-A
Copy link
Copy Markdown
Contributor

@Saira-A Saira-A commented Jun 19, 2025

This option limits the number of characters displayed in the attribution text (counting characters from the start of the raw HTML string). Trimming too short may prevent images or links from displaying correctly.

Not sure how useful this actually is; might be better to just remove it?

Manifest for testing: https://iiif.io/api/cookbook/recipe/0008-rights/manifest.json

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 1:19pm

@demiankatz
Copy link
Copy Markdown
Contributor

@Saira-A, I did a bit of digging and found that this setting was disabled in commit 1ba9d71 without explanation... but it has been disabled for eight years (since v3.1.1) without anyone noticing or complaining.

I tried to go further back in time to see when and why the setting was added, but there's a lot of major refactoring that makes it hard to track down.

I think at this point, I might be more inclined to treat it as an orphan and remove it, rather than try to make it work if we're not sure of a use case. We can discuss on a future standup!

@Saira-A Saira-A changed the title Fix trimAttributionCount configuration option Remove trimAttributionCount configuration option Jun 19, 2025
@Saira-A
Copy link
Copy Markdown
Contributor Author

Saira-A commented Jun 19, 2025

I think at this point, I might be more inclined to treat it as an orphan and remove it, rather than try to make it work if we're not sure of a use case. We can discuss on a future standup!

I agree, have edited to remove it instead

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Saira-A!

@demiankatz demiankatz moved this from WORK IN PROGRESS to IN TESTING in DEV EX Community Sprint May-July 2025 Jun 20, 2025
@LanieOkorodudu
Copy link
Copy Markdown
Collaborator

I think at this point, I might be more inclined to treat it as an orphan and remove it, rather than try to make it work if we're not sure of a use case. We can discuss on a future standup!

I agree, have edited to remove it instead

Thanks @Saira-A, Also good to remove it as well in the config doc, line 937-940

@demiankatz demiankatz merged commit b9a098c into UniversalViewer:dev Jun 20, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from IN TESTING to COMPLETED in DEV EX Community Sprint May-July 2025 Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

3 participants