Remove trimAttributionCount configuration option#1456
Remove trimAttributionCount configuration option#1456demiankatz merged 5 commits intoUniversalViewer:devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Saira-A, I did a bit of digging and found that this setting was disabled in commit 1ba9d71 without explanation... but it has been disabled for eight years (since v3.1.1) without anyone noticing or complaining. I tried to go further back in time to see when and why the setting was added, but there's a lot of major refactoring that makes it hard to track down. I think at this point, I might be more inclined to treat it as an orphan and remove it, rather than try to make it work if we're not sure of a use case. We can discuss on a future standup! |
…versalviewer into trimAttributionCount
I agree, have edited to remove it instead |
Thanks @Saira-A, Also good to remove it as well in the config doc, line 937-940 |
This option limits the number of characters displayed in the attribution text (counting characters from the start of the raw HTML string). Trimming too short may prevent images or links from displaying correctly.
Not sure how useful this actually is; might be better to just remove it?
Manifest for testing: https://iiif.io/api/cookbook/recipe/0008-rights/manifest.json