Skip to content

Rolling Edsilv/utils into the uv#1505

Merged
demiankatz merged 10 commits intoUniversalViewer:devfrom
Geoffsc:EdSilvUtils
Aug 18, 2025
Merged

Rolling Edsilv/utils into the uv#1505
demiankatz merged 10 commits intoUniversalViewer:devfrom
Geoffsc:EdSilvUtils

Conversation

@Geoffsc
Copy link
Copy Markdown
Contributor

@Geoffsc Geoffsc commented Jul 18, 2025

#1380

Rolling Edsilv/utils into the uv:

  • added Utils class
  • updated references
  • removed npm package
    - updated webpack config to compile Utils.js outside the bundle
    - updated compiled Utils.js file references

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
universalviewer Ready Ready Preview Comment Aug 18, 2025 0:33am

@demiankatz
Copy link
Copy Markdown
Contributor

Thanks, @Geoffsc, this seems to be working for me, though the webpack parts may go a little over my head. When I view the preview and inspect the browser console, I don't see a Utils.js getting downloaded, so I'm not sure where that piece fits into the puzzle....

I also tried disabling the download and share options in the footer panel just to confirm that the Bools library is getting exercised correctly. It didn't work for me, but it also doesn't work on the dev branch, so I'm wondering if there's some larger configuration problem at hand (or, equally likely, whether I'm just doing something wrong). That may be a separate rabbit hole for us to fall down....

@Geoffsc
Copy link
Copy Markdown
Contributor Author

Geoffsc commented Jul 21, 2025

@demiankatz that's a great catch -- I attempted a small webpack config fix but it looks like this will require more effort and possibly multiple webpack configurations to fix, since this would require no longer bundling everything within UV.js. I wonder if it's worth having a dev call specifically for this with other folks who have webpack config experience. Possibly there's an easier fix that is eluding me at the moment!

@demiankatz
Copy link
Copy Markdown
Contributor

Thanks, @Geoffsc! I think a related question (which I've already partially raised before) is: what is the purpose of mobile.html and production.html? I'm not sure how these files are used, and the hard-coded external dependencies in them concern me. If these are obsolete and can be removed, maybe that will simplify things; if they are needed, it would be good to understand why and how so that we can consider possible improvements.

@LanieOkorodudu
Copy link
Copy Markdown
Collaborator

Tested this and functionality wise it work as expected. Thanks @Geoffsc. I will leave it to you @demiankatz to decide if this can be merged or your suggestion above needs to be address first before merging. Thanks to both of you.

@Geoffsc
Copy link
Copy Markdown
Contributor Author

Geoffsc commented Jul 24, 2025

Thanks @LanieOkorodudu! I'm not super comfortable merging this in its current state because the references in mobile.html and production.html are most likely incorrect due to the need for likely more comprehensive webpack config changes. I would probably recommend to decide one of two options:

  1. If those html files are still being used, we will need a more comprehensive webpack config update
    or
  2. If those html files aren't still being used, can we simply stop maintaining them?

@demiankatz
Copy link
Copy Markdown
Contributor

This may be a good discussion topic for the next UV Community Call. @erinburnand, would you like to put it on the agenda? This also reminds me that I will be on vacation and expect to miss that call (currently scheduled for August 7). The show is welcome to go on without me, but if you want to delay to August 14, then I could make it.

@Geoffsc
Copy link
Copy Markdown
Contributor Author

Geoffsc commented Aug 14, 2025

Per our conversation in the community call today I completely backed out the webpack config changes and the mobile.html and production.html reference changes and pushed that all to this PR. I will open a separate PR to handle removing those html files as from investigation it appears they are no longer being used.

Edit: here's the PR to remove the 2 html files

@demiankatz
Copy link
Copy Markdown
Contributor

Thanks again, @Geoffsc -- now that #1524 is merged, do you mind merging the dev branch back into this PR so we can do one last test with all the pieces pulled together? (I expect it should be fine, but just want to play it safe!)

Keeping this branch up to date with latest in dev
@Geoffsc
Copy link
Copy Markdown
Contributor Author

Geoffsc commented Aug 18, 2025

Thanks again, @Geoffsc -- now that #1524 is merged, do you mind merging the dev branch back into this PR so we can do one last test with all the pieces pulled together? (I expect it should be fine, but just want to play it safe!)

Sure, done!

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're in good shape now. Thanks again, @Geoffsc!

@demiankatz demiankatz merged commit d78679a into UniversalViewer:dev Aug 18, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In testing to Completed in Universal Viewer Community Board Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

3 participants