Rolling Edsilv/utils into the uv#1505
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks, @Geoffsc, this seems to be working for me, though the webpack parts may go a little over my head. When I view the preview and inspect the browser console, I don't see a Utils.js getting downloaded, so I'm not sure where that piece fits into the puzzle.... I also tried disabling the download and share options in the footer panel just to confirm that the Bools library is getting exercised correctly. It didn't work for me, but it also doesn't work on the dev branch, so I'm wondering if there's some larger configuration problem at hand (or, equally likely, whether I'm just doing something wrong). That may be a separate rabbit hole for us to fall down.... |
|
@demiankatz that's a great catch -- I attempted a small webpack config fix but it looks like this will require more effort and possibly multiple webpack configurations to fix, since this would require no longer bundling everything within UV.js. I wonder if it's worth having a dev call specifically for this with other folks who have webpack config experience. Possibly there's an easier fix that is eluding me at the moment! |
|
Thanks, @Geoffsc! I think a related question (which I've already partially raised before) is: what is the purpose of mobile.html and production.html? I'm not sure how these files are used, and the hard-coded external dependencies in them concern me. If these are obsolete and can be removed, maybe that will simplify things; if they are needed, it would be good to understand why and how so that we can consider possible improvements. |
|
Tested this and functionality wise it work as expected. Thanks @Geoffsc. I will leave it to you @demiankatz to decide if this can be merged or your suggestion above needs to be address first before merging. Thanks to both of you. |
|
Thanks @LanieOkorodudu! I'm not super comfortable merging this in its current state because the references in mobile.html and production.html are most likely incorrect due to the need for likely more comprehensive webpack config changes. I would probably recommend to decide one of two options:
|
|
This may be a good discussion topic for the next UV Community Call. @erinburnand, would you like to put it on the agenda? This also reminds me that I will be on vacation and expect to miss that call (currently scheduled for August 7). The show is welcome to go on without me, but if you want to delay to August 14, then I could make it. |
|
Per our conversation in the community call today I completely backed out the webpack config changes and the Edit: here's the PR to remove the 2 html files |
Keeping this branch up to date with latest in dev
demiankatz
left a comment
There was a problem hiding this comment.
I think we're in good shape now. Thanks again, @Geoffsc!
#1380
Rolling Edsilv/utils into the uv:
- updated webpack config to compile Utils.js outside the bundle- updated compiled Utils.js file references